Re: [jboss-cvs] jboss-system/src/main/org/jboss/deployment/scanner URLDirectoryScanner.java

[Larry S. <la...@mr...>]

I think David could speak to this better than I, but here is my take: When a
dependency is not yet met, a DeploymentException is thrown, and the scanner
simply sits on it until at some point the dependency is met.  On start-up, if
there are circular class dependencies, or your deployments just don't go in the
"correct" order, then these exceptions are logged until the corresponding
package is deployed.

I think David already had a similar patch in URLDeploymentScanner.

-Larry


> Perhaps, though I think this is misuse of the logging system.  I haven't
> started up an instance from HEAD in a bit, but why are there exceptions
> on startup?
>
> --jason
>
>
> > -----Original Message-----
> > From: Larry Sanderson [mailto:la...@mr...]
> > Sent: Wednesday, August 21, 2002 3:52 PM
> > To: Jason Dillon; 'Larry Sanderson'; jboss-cvs-
> > co...@li...
> > Subject: Re: [jboss-cvs] jboss-
> > system/src/main/org/jboss/deployment/scanner URLDirectoryScanner.java
> >
> > Because unless you are debugging something, you would not care what
> line-
> > numbers
> > and classes the source of a missing dependency is coming from.  Also,
> the
> > dependency error messages alone are plenty verbose enough to describe
> > exactly
> > what is going on.  But, more to the point, all those stack traces on
> > startup was
> > really starting to annoy me.
> >
> > -Larry
> >
> >
> > > Why?
> > >
> > > --jason
> > >
> > >
> > > > -----Original Message-----
> > > > From: jbo...@li...
> [mailto:jboss-cvs-
> > > > com...@li...] On Behalf Of Larry Sanderson
> > > > Sent: Wednesday, August 21, 2002 3:20 PM
> > > > To: jbo...@li...
> > > > Subject: [jboss-cvs]
> > > jboss-system/src/main/org/jboss/deployment/scanner
> > > > URLDirectoryScanner.java
> > > >
> > > >   User: lsanders
> > > >   Date: 02/08/21 15:20:08
> > > >
> > > >   Modified:    src/main/org/jboss/deployment/scanner Tag:
> Branch_3_0
> > > >                         URLDirectoryScanner.java
> > > >   Log:
> > > >   Removed deployment-dependency stack traces, except in debug
> mode.
> > > >
> > > >   Revision  Changes    Path
> > > >   No                   revision
> > > >
> > > >
> > > >   No                   revision
> > > >
> > > >
> > > >   1.1.2.2   +4 -1      jboss-
> > > >
> system/src/main/org/jboss/deployment/scanner/URLDirectoryScanner.java
> > > >
> > > >   Index: URLDirectoryScanner.java
> > > >
> ===================================================================
> > > >   RCS file: /cvsroot/jboss/jboss-
> > > >
> > >
> system/src/main/org/jboss/deployment/scanner/URLDirectoryScanner.java,v
> > > >   retrieving revision 1.1.2.1
> > > >   retrieving revision 1.1.2.2
> > > >   diff -u -r1.1.2.1 -r1.1.2.2
> > > >   --- URLDirectoryScanner.java 24 Apr 2002 15:24:21 -0000
> > > 1.1.2.1
> > > >   +++ URLDirectoryScanner.java 21 Aug 2002 22:20:06 -0000
> > > 1.1.2.2
> > > >   @@ -398,7 +398,10 @@
> > > >                      deploy();
> > > >                   } catch (DeploymentException e)
> > > >                   {
> > > >   -                  getLog().error("Failed to (re)deploy url: " +
> > > url,
> > > > e);
> > > >   +                  if (getLog().isDebugEnabled())
> > > >   +                      getLog().error("Failed to (re)deploy url:
> " +
> > > > url, e);
> > > >   +                  else
> > > >   +                      getLog().error("Failed to (re)deploy url:
> " +
> > > url
> > > > + ".  " + e);
> > > >                   }
> > > >                } else
> > > >                {
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > -------------------------------------------------------
> > > > This sf.net email is sponsored by: OSDN - Tired of that same old
> > > > cell phone?  Get a new here for FREE!
> > > > https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
> > > > _______________________________________________
> > > > jboss-cvs-commits mailing list
> > > > jbo...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/jboss-cvs-commits
> > >
>