Menu
▾
▴
[Javagit-bugs] [ javagit-Bugs-2036823 ] Change *Iterator to *Iterable methods in GitStatusResponse
|
From: SourceForge.net <no...@so...> - 2008-08-03 21:32:42
|
Bugs item #2036823, was opened at 2008-08-03 10:47 Message generated for change (Settings changed) made by jhlinder You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1089899&aid=2036823&group_id=233450 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Commands API >Group: v0.1.0 (fixed in) >Status: Closed Resolution: Fixed Priority: 8 Private: No Submitted By: James H. Linder (jhlinder) Assigned to: Gurdeep Dhindsa (dhindsg) Summary: Change *Iterator to *Iterable methods in GitStatusResponse Initial Comment: GitStatusResponse has a few methods that return Iterable objects. They should have their names updated to be consistently named and to reflect the fact that they no longer return Iterators. Their JavaDocs also need to be updated to reflect the fact that they return Iterable. The methods are: getNewFilesToCommitIterarator() getDeletedFilesToCommitIterator() getModifiedFilesToCommitIterator() getDeletedFilesNotUpdatedIterator() getModifiedFilesNotUpdatedIterator() getRenamedFilesToCommitIterator() getUntrackedFiles() ---------------------------------------------------------------------- Comment By: Gurdeep Dhindsa (dhindsg) Date: 2008-08-03 15:59 Message: Logged In: YES user_id=2143686 Originator: NO Method names have been changed to - public Iterable<File> getNewFilesToCommit() public Iterable<File> getDeletedFilesToCommit() public Iterable<File> getModifiedFilesToCommit() public Iterable<File> getDeletedFilesNotUpdated() public Iterable<File> getModifiedFilesNotUpdated() public Iterable<File> getRenamedFilesToCommit() public Iterable<File> getUntrackedFiles() Mail is also sent to gitclipse-devel team. ---------------------------------------------------------------------- Comment By: Gurdeep Dhindsa (dhindsg) Date: 2008-08-03 15:44 Message: Logged In: YES user_id=2143686 Originator: NO Method names have been changed to - public Iterable<File> getNewFilesToCommit() public Iterable<File> getDeletedFilesToCommit() public Iterable<File> getModifiedFilesToCommit() public Iterable<File> getDeletedFilesNotUpdated() public Iterable<File> getModifiedFilesNotUpdated() public Iterable<File> getRenamedFilesToCommit() public Iterable<File> getUntrackedFiles() Mail is also sent to gitclipse-devel team. ---------------------------------------------------------------------- Comment By: James H. Linder (jhlinder) Date: 2008-08-03 13:55 Message: Logged In: YES user_id=1099750 Originator: YES Looks good. Closing and marking fixed in 0.1.0. ---------------------------------------------------------------------- Comment By: Gurdeep Dhindsa (dhindsg) Date: 2008-08-03 12:50 Message: Logged In: YES user_id=2143686 Originator: NO Method names have been changed to - public Iterable<File> getNewFilesToCommit() public Iterable<File> getDeletedFilesToCommit() public Iterable<File> getModifiedFilesToCommit() public Iterable<File> getDeletedFilesNotUpdated() public Iterable<File> getModifiedFilesNotUpdated() public Iterable<File> getRenamedFilesToCommit() public Iterable<File> getUntrackedFiles() Mail is also sent to gitclipse-devel team. ---------------------------------------------------------------------- Comment By: Gurdeep Dhindsa (dhindsg) Date: 2008-08-03 12:49 Message: Logged In: YES user_id=2143686 Originator: NO Method names have been changed to - public Iterable<File> getNewFilesToCommit() public Iterable<File> getDeletedFilesToCommit() public Iterable<File> getModifiedFilesToCommit() public Iterable<File> getDeletedFilesNotUpdated() public Iterable<File> getModifiedFilesNotUpdated() public Iterable<File> getRenamedFilesToCommit() public Iterable<File> getUntrackedFiles() Mail is also sent to gitclipse-devel team. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1089899&aid=2036823&group_id=233450 |