#2 Dependency on pde.core

[Philippe Ombredanne]

Hi:
Jar-plug has an un-used dependency on the the plugin:
org.eclipse.pde.core....
Based on my test, It could be safely removed from the
dependencies, and limit jarplug usage to environments
that have PDE installed
:-)

[Philippe Ombredanne]

Logged In: YES
user_id=879778

In fact my wrong, that dependency is needed, but could be
made optional:
<import plugin="org.eclipse.pde.core" optional="true"/>
Since this is to make a reference to the internal PDE class
FileAdapter in an instanceof, the dependency could be
optional I guess, and the plugin would still work fine when
PDE is not installed.
I tested it on the CVS HEAD and it works fine.
Here would be a patch: :-)

Cordially

Index: plugin.xml

RCS file: /cvsroot/jar-plug/jar-plug/plugin.xml,v
retrieving revision 1.6
diff -u -r1.6 plugin.xml
--- plugin.xml 15 Nov 2004 18:37:57 -0000 1.6
+++ plugin.xml 20 Jun 2006 01:38:47 -0000
@@ -23,7 +23,7 @@
<import plugin="org.eclipse.ui.workbench.texteditor"/>
<import plugin="org.eclipse.jdt.ui"/>
<import plugin="org.eclipse.ui.views"/>
- <import plugin="org.eclipse.pde.core"/>
+ <import plugin="org.eclipse.pde.core" optional="true"/>
</requires>

<extension