[Japi-cvs] SF.net SVN: japi: [545] libs/swing-list/trunk/src/net/sf/japi/swing/list/ ArrayListModel.java

[<chr...@us...>]

Revision: 545
          http://svn.sourceforge.net/japi/?rev=545&view=rev
Author:   christianhujer
Date:     2007-07-14 09:51:38 -0700 (Sat, 14 Jul 2007)

Log Message:
-----------
Changed remove() to throw IllegalArgumentException for not-contained elements to be consistent with move() operations.

Modified Paths:
--------------
    libs/swing-list/trunk/src/net/sf/japi/swing/list/ArrayListModel.java

Modified: libs/swing-list/trunk/src/net/sf/japi/swing/list/ArrayListModel.java
===================================================================
--- libs/swing-list/trunk/src/net/sf/japi/swing/list/ArrayListModel.java	2007-07-14 16:42:49 UTC (rev 544)
+++ libs/swing-list/trunk/src/net/sf/japi/swing/list/ArrayListModel.java	2007-07-14 16:51:38 UTC (rev 545)
@@ -19,9 +19,9 @@
 
 package net.sf.japi.swing.list;
 
-import java.util.List;
 import java.util.ArrayList;
 import java.util.Iterator;
+import java.util.List;
 import org.jetbrains.annotations.Nullable;
 
 /** ArrayList-backed implementation of {@link MutableListModel}.
@@ -68,7 +68,7 @@
     /** {@inheritDoc} */
     public boolean remove(final E e) {
         if (!list.contains(e)) {
-            return false;
+            throw new IllegalArgumentException("Element " + e + " not part of " + this);
         }
         final int index;
         final boolean retVal;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.