[Japi-cvs] SF.net SVN: japi: [500] libs/argparser/trunk/src

[<chr...@us...>]

Revision: 500
          http://svn.sourceforge.net/japi/?rev=500&view=rev
Author:   christianhujer
Date:     2007-07-05 13:52:11 -0700 (Thu, 05 Jul 2007)

Log Message:
-----------
Fixed checkstyle issues.

Modified Paths:
--------------
    libs/argparser/trunk/src/net/sf/japi/io/args/LogCommand.java
    libs/argparser/trunk/src/net/sf/japi/io/args/converter/ConstructorConverter.java
    libs/argparser/trunk/src/test/net/sf/japi/io/args/MethodOptionComparatorTest.java

Modified: libs/argparser/trunk/src/net/sf/japi/io/args/LogCommand.java
===================================================================
--- libs/argparser/trunk/src/net/sf/japi/io/args/LogCommand.java	2007-07-05 20:48:04 UTC (rev 499)
+++ libs/argparser/trunk/src/net/sf/japi/io/args/LogCommand.java	2007-07-05 20:52:11 UTC (rev 500)
@@ -30,7 +30,7 @@
 public abstract class LogCommand extends BasicCommand {
 
     /** The Logger to use. */
-    protected final Logger log;
+    private final Logger log;
 
     /** Create a LogCommand with the specified log.
      * @param log Logger to use
@@ -52,4 +52,11 @@
         log.setLevel(level);
     }
 
+    /** Returns the logger.
+     * @return The Logger.
+     */
+    public Logger getLog() {
+        return log;
+    }
+
 } // class LogCommand

Modified: libs/argparser/trunk/src/net/sf/japi/io/args/converter/ConstructorConverter.java
===================================================================
--- libs/argparser/trunk/src/net/sf/japi/io/args/converter/ConstructorConverter.java	2007-07-05 20:48:04 UTC (rev 499)
+++ libs/argparser/trunk/src/net/sf/japi/io/args/converter/ConstructorConverter.java	2007-07-05 20:52:11 UTC (rev 500)
@@ -25,8 +25,7 @@
 
 /**
  * Converter that performs a conversion by
- * Created by IntelliJ IDEA.
- *
+ * @param <T> target type to convert to.
  * @author <a href="mailto:ch...@ri...">Christian Hujer</a>
  */
 public class ConstructorConverter<T> extends AbstractConverter<T> {

Modified: libs/argparser/trunk/src/test/net/sf/japi/io/args/MethodOptionComparatorTest.java
===================================================================
--- libs/argparser/trunk/src/test/net/sf/japi/io/args/MethodOptionComparatorTest.java	2007-07-05 20:48:04 UTC (rev 499)
+++ libs/argparser/trunk/src/test/net/sf/japi/io/args/MethodOptionComparatorTest.java	2007-07-05 20:52:11 UTC (rev 500)
@@ -46,7 +46,7 @@
         final Method mBar  = cmdClass.getMethod("bar");
         final Method mBuzz = cmdClass.getMethod("buzz");
         final Method mA    = cmdClass.getMethod("a");
-        final Method mZ    = cmdClass.getMethod("Z");
+        final Method mZ    = cmdClass.getMethod("z");
         Assert.assertTrue("-a must be sorted before -b / --bar.", comparator.compare(mA, mBar) < 0);
         Assert.assertTrue("-b / --bar must be sorted before --buzz.", comparator.compare(mBar, mBuzz) < 0);
         Assert.assertTrue("--buzz must be sorted before -f / --foo.", comparator.compare(mBuzz, mFoo) < 0);
@@ -61,8 +61,8 @@
     public void testCompareCase() throws NoSuchMethodException {
         final Comparator<Method> comparator = MethodOptionComparator.INSTANCE;
         final Class<MockCommand> cmdClass = MockCommand.class;
-        final Method mC1   = cmdClass.getMethod("c");
-        final Method mC2   = cmdClass.getMethod("C");
+        final Method mC1   = cmdClass.getMethod("c1");
+        final Method mC2   = cmdClass.getMethod("c2");
         Assert.assertTrue("-c and -C must not be the same.", comparator.compare(mC1, mC2) != 0);
     }
 
@@ -74,31 +74,31 @@
 
         /** Dummy command method. */
         @Option({"f", "foo"})
-        public void foo() {}
+        public void foo() { }
 
         /** Dummy command method. */
         @Option({"b", "bar"})
-        public void bar() {}
+        public void bar() { }
 
         /** Dummy command method. */
         @Option({"buzz"})
-        public void buzz() {}
+        public void buzz() { }
 
         /** Dummy command method. */
         @Option({"Z"})
-        public void Z() {}
+        public void z() { }
 
         /** Dummy command method. */
         @Option({"a"})
-        public void a() {}
+        public void a() { }
 
         /** Dummy command method. */
         @Option({"c"})
-        public void c() {}
+        public void c1() { }
 
         /** Dummy command method. */
         @Option({"C"})
-        public void C() {}
+        public void c2() { }
 
         /** {@inheritDoc} */
         @SuppressWarnings({"InstanceMethodNamingConvention"})


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.