[Japi-cvs] SF.net SVN: japi:[1353] progs/jtype/trunk/src/prj/net/sf/japi/jtype/Helper. java

[<chr...@us...>]

Revision: 1353
          http://japi.svn.sourceforge.net/japi/?rev=1353&view=rev
Author:   christianhujer
Date:     2009-06-14 09:32:01 +0000 (Sun, 14 Jun 2009)

Log Message:
-----------
Improve exception handling.

Modified Paths:
--------------
    progs/jtype/trunk/src/prj/net/sf/japi/jtype/Helper.java

Modified: progs/jtype/trunk/src/prj/net/sf/japi/jtype/Helper.java
===================================================================
--- progs/jtype/trunk/src/prj/net/sf/japi/jtype/Helper.java	2009-06-14 09:31:39 UTC (rev 1352)
+++ progs/jtype/trunk/src/prj/net/sf/japi/jtype/Helper.java	2009-06-14 09:32:01 UTC (rev 1353)
@@ -100,10 +100,14 @@
             final List<String> lines = new ArrayList<String>();
             @SuppressWarnings({"IOResourceOpenedButNotSafelyClosed"})
             final BufferedReader in = new BufferedReader(new InputStreamReader(process.getInputStream()));
-            for (String line; (line = in.readLine()) != null;) {
-                lines.add(line);
+            try {
+                for (String line; (line = in.readLine()) != null;) {
+                    lines.add(line);
+                }
+                return lines;
+            } finally {
+                in.close();
             }
-            return lines;
         } catch (final IOException e) {
             e.printStackTrace();
             return Collections.EMPTY_LIST;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.