[Jamin] [aj@andaco.de: Bug#264725: jamin: FTBFS with gcc-3.4: conflicting types for 'set_EQ_curve_values']

[Robert J. <rob...@ph...>]

Hi!

This patch reached me via a Debian Bug report. What do you think?

        Robert.

----- Forwarded message from Andreas Jochens <aj...@an...> -----

=46rom: Andreas Jochens <aj...@an...>
Subject: Bug#264725: jamin: FTBFS with gcc-3.4: conflicting types for 'set_=
EQ_curve_values'
To: Debian Bug Tracking System <su...@bu...>
Date: Tue, 10 Aug 2004 09:46:23 +0200
Reply-To: Andreas Jochens <aj...@an...>, 26...@bu...
Message-Id: <E1BuRKx-0002Ii-KR@localhost>

Package: jamin
Severity: normal
Tags: patch

When building 'jamin' with gcc-3.4 I get the following error:

scenes.c:63: error: conflicting types for 'set_EQ_curve_values'
scenes.c:63: note: an argument type that has a default promotion can't matc=
h an empty parameter name list declaration
hdeq.h:48: error: previous declaration of 'set_EQ_curve_values' was here
scenes.c:63: error: conflicting types for 'set_EQ_curve_values'
scenes.c:63: note: an argument type that has a default promotion can't matc=
h an empty parameter name list declaration
hdeq.h:48: error: previous declaration of 'set_EQ_curve_values' was here
make[3]: *** [jamin-scenes.o] Error 1
make[3]: Leaving directory `/jamin-0.9.0/src'

With the attached patch 'jamin' can be compiled using gcc-3.4.

Regards
Andreas Jochens

diff -urN ../tmp-orig/jamin-0.9.0/src/scenes.c ./src/scenes.c
--- ../tmp-orig/jamin-0.9.0/src/scenes.c	2004-05-09 18:38:40.000000000 +0200
+++ ./src/scenes.c	2004-08-10 09:31:45.750402978 +0200
@@ -60,7 +60,6 @@
                          *LED_yellow =3D NULL, *LED_red =3D NULL;
=20
=20
-void set_EQ_curve_values ();
=20
=20
 /*  Initialize all scene related structures and get the widget addresses. =
 */
@@ -210,7 +209,7 @@
=20
                         s_crossfade_to_state (&scene_state[i], -1.0f);
=20
-                        set_EQ_curve_values ();
+                        set_EQ_curve_values (0, 0.0);
=20
                         s_history_add_state (scene_state[i]);
=20

----- End forwarded message -----

--=20
But you'll notice Perl has a goto.
             -- Larry Wall in <199...@wa...>