Re: [Jajuk-dev] [Jajuk-commits] SF.net SVN: jajuk:[5527] trunk/jajuk/src/main/java/org/jajuk/base/Item.java

[Bertrand F. <ber...@fl...>]

All right, I checked MAT and it's a powerful beast pretty well
documented (not very simple through). Were did you find the find
duplicate strings feature ? I cannot figured out where it is... (I use
the last available version from the update manager).


Bertrand Florat wrote:
> Really ? fine. I wasn't ware of it. thanks for the tip, I'll check
> http://www.eclipse.org/mat/ .
>
> On Tue, Nov 17, 2009 at 1:07 PM, Dominik Stadler <dom...@gm...>wrote:
>
>   
>> Yes, I played around with the Eclipse Memory Analyzer feature and it has a
>> "search for duplicate strings" functionality that clearly showed these two,
>> seems this tool is really useful for such investigation!
>>
>> Currently there is only a constant for "none.jpg", not "none", but I will
>> add one and use it in Album and Item and other places.
>>
>> Dominik.
>>
>> On Tue, Nov 17, 2009 at 12:26 PM, Bertrand Florat <ber...@fl...>wrote:
>>
>>     
>>> Good idea. BTW, don't we have a constant for "none" string so we could do
>>> a
>>> CONST.xxx.equals(sValue))  ?
>>>
>>> On Tue, Nov 17, 2009 at 12:03 AM, <ce...@us...> wrote:
>>>
>>>       
>>>> Revision: 5527
>>>>          http://jajuk.svn.sourceforge.net/jajuk/?rev=5527&view=rev
>>>> Author:   centic
>>>> Date:     2009-11-16 23:03:00 +0000 (Mon, 16 Nov 2009)
>>>>
>>>> Log Message:
>>>> -----------
>>>> small memory optimization: there are some properties that we do not
>>>> automatically intern() during collection loading, therefore do it
>>>>         
>>> manually
>>>       
>>>> here to not have the strings duplicated.
>>>>
>>>> This is currently useful for "ALBUM_ARTIST" and for "none" Cover in
>>>>         
>>> Albums
>>>       
>>>> Measured gain: aprox. 1MB of heap memory for 25000 tracks
>>>>
>>>> Modified Paths:
>>>> --------------
>>>>    trunk/jajuk/src/main/java/org/jajuk/base/Item.java
>>>>
>>>> Modified: trunk/jajuk/src/main/java/org/jajuk/base/Item.java
>>>> ===================================================================
>>>> --- trunk/jajuk/src/main/java/org/jajuk/base/Item.java  2009-11-16
>>>>         
>>> 22:25:09
>>>       
>>>> UTC (rev 5526)
>>>> +++ trunk/jajuk/src/main/java/org/jajuk/base/Item.java  2009-11-16
>>>>         
>>> 23:03:00
>>>       
>>>> UTC (rev 5527)
>>>> @@ -432,7 +432,16 @@
>>>>         PropertyMetaInformation meta = getMeta(sProperty);
>>>>         try {
>>>>           if (meta != null) {
>>>> -            setProperty(sProperty, UtilString.parse(sValue,
>>>> meta.getType()));
>>>> +            // small memory optimization: there are some properties
>>>>         
>>> that
>>>       
>>>> we do not automatically intern during collection loading,
>>>> +            // therefore do it manually here to not have the strings
>>>> duplicated.
>>>> +            // This is currently useful for "ALBUM_ARTIST" and for
>>>>         
>>> "none"
>>>       
>>>> Cover in Albums
>>>> +            // measured gain: aprox. 1MB for 25k tracks
>>>> +            if(Const.XML_ALBUM_ARTIST.equals(sProperty) ||
>>>> +                "none".equals(sValue)) {
>>>> +              setProperty(sProperty, UtilString.parse(sValue.intern(),
>>>> meta.getType()));
>>>> +            } else {
>>>> +              setProperty(sProperty, UtilString.parse(sValue,
>>>> meta.getType()));
>>>> +            }
>>>>           }
>>>>         } catch (Exception e) {
>>>>           Log.error(137, sProperty, e);
>>>>
>>>>
>>>> This was sent by the SourceForge.net collaborative development platform,
>>>> the world's largest Open Source development site.
>>>>
>>>>
>>>>
>>>>         
>>> ------------------------------------------------------------------------------
>>>       
>>>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
>>>>         
>>> 30-Day
>>>       
>>>> trial. Simplify your report design, integration and deployment - and
>>>>         
>>> focus
>>>       
>>>> on
>>>> what you do best, core application coding. Discover what's new with
>>>> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>>>> _______________________________________________
>>>> Jajuk-commits mailing list
>>>> Jaj...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/jajuk-commits
>>>>
>>>>         
>>>
>>> --
>>> Bertrand FLORAT
>>> ber...@fl...
>>> http://www.florat.net
>>> PGP keyserver:  pgp.mit.edu
>>> Try Jajuk Advanced jukebox (http://jajuk.info)
>>>
>>> ------------------------------------------------------------------------------
>>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
>>> 30-Day
>>> trial. Simplify your report design, integration and deployment - and focus
>>> on
>>> what you do best, core application coding. Discover what's new with
>>> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>>> _______________________________________________
>>> Jajuk-developers mailing list
>>> Jaj...@li...
>>> https://lists.sourceforge.net/lists/listinfo/jajuk-developers
>>>
>>>       
>>     
>
>
>   


-- 
Bertrand FLORAT         
ber...@fl...
http://www.florat.net
PGP keyserver:  pgp.mit.edu  
Try Jajuk Advanced jukebox (http://jajuk.info)