Menu

#70 External components support

open
Rion
Protocol (9)
9
2010-07-11
2010-05-26
No

the contacts added by roster exchange from an external component should be authorized without user confirmation

We have to check if the roster exchange request comes from an external component to avoid illegal use of the roster exchange.

We have to block the “This user wants to change your roster” popup when the request comes from a transport

We have to hide the external components contact in the main roster

To achieve all the above we have 2 ways :
1) Use a function similar to line 2876 of psiaccount.cpp
2) When a new external component is added to the roster automatically add it to the "Transports" Group. External components provide exactly the same functions of a Transport.

Solution 2) should be better/simpler to adopt

Discussion

  • Ivan Čukić

    Ivan Čukić - 2010-06-02

    How to test this?

     
  • Andrea Bodrati

    Andrea Bodrati - 2010-06-02

    You can add a test skype or QQ account with 4 or 5 contacts. Right now you will see one request to authorize/decline each contact while contacts should be added automatically without any confirmation

     
  • Ivan Čukić

    Ivan Čukić - 2010-06-20

    Adding it to the transports group doesn't help remove the popups (just tested)

    Is there a possibility to do that on the server side so that client thinks it is a transport?

     
  • Andrea Bodrati

    Andrea Bodrati - 2010-06-20

    Unfortunately not. In case of external component there is no <Group> definition.

    I was hoping that adding the external component JID to the Transports group would fix it since in the code it seems that we just check the Group but maybe there is something else.

    We should than use a function similar to line 2876 of psiaccount.cpp: in case the JID is transportname.jabbin.com don't show any popup and automatically add the contacts

     
  • Andrea Bodrati

    Andrea Bodrati - 2010-07-11
    • assigned_to: ivan-cukic --> rion_wis
     

Log in to post a comment.