Re: [Iverilog-devel] Pull request

[Stephen W. <st...@ic...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Thanks,

I'll take a look and merge it as soon as I can. (Busy day today.)

On 02/24/2016 07:46 AM, Maciej Sumiński wrote:
> On 02/20/2016 03:00 AM, Stephen Williams wrote:
>> On 02/15/2016 08:29 AM, Maciej Sumiński wrote:
>>> It would be great if the ivl & vvp changes were reviewed more 
>>> carefully. recv_vec4_pv() seemed suspiciously simple, and I am 
>>> afraid I might have missed something important there.
>> 
>> You did! What you missed is that those methods should be 
>> implemented in the derived classes, and not the vvp_net_fun_t 
>> class itself. The vvp_net_fun_t is used kinda like an abstract 
>> base class.
> 
> Thank you for the notice. I have already fixed it and rebased the
> branch.
> 
> I am still not sure about the semantics though. It works for me,
> and there is a test [1] that demonstrates what I was trying to
> achieve, but I do not know if it covers all possible cases.
> 
> Regards, Orson
> 
> 1. 
> https://github.com/orsonmmz/ivtest/commit/bf46c7d1eaddeec88a0c21a6208a2cd3a51b85d1
>
> 
- -- 
Steve Williams                "The woods are lovely, dark and deep.
steve at icarus.com           But I have promises to keep,
http://www.icarus.com         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlbN1u4ACgkQrPt1Sc2b3ik8GACgk5CHibXMWIFvY4vZPmcftj84
dkgAniRtGIel5YIsYf8Zg9g/D0oX4NEJ
=Ir0E
-----END PGP SIGNATURE-----