Re: [Iverilog-devel] Pull request

[Maciej S. <mac...@ce...>]

On 02/20/2016 03:00 AM, Stephen Williams wrote:
> On 02/15/2016 08:29 AM, Maciej Sumiński wrote:
>> It would be great if the ivl & vvp changes were reviewed more
>> carefully. recv_vec4_pv() seemed suspiciously simple, and I am
>> afraid I might have missed something important there.
> 
> You did! What you missed is that those methods should be
> implemented in the derived classes, and not the vvp_net_fun_t
> class itself. The vvp_net_fun_t is used kinda like an abstract
> base class.

Thank you for the notice. I have already fixed it and rebased the branch.

I am still not sure about the semantics though. It works for me, and
there is a test [1] that demonstrates what I was trying to achieve, but
I do not know if it covers all possible cases.

Regards,
Orson

1.
https://github.com/orsonmmz/ivtest/commit/bf46c7d1eaddeec88a0c21a6208a2cd3a51b85d1