Re: [Iverilog-devel] Pull request

[Stephen W. <st...@ic...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/15/2016 08:29 AM, Maciej Sumiński wrote:
> It would be great if the ivl & vvp changes were reviewed more
> carefully. recv_vec4_pv() seemed suspiciously simple, and I am
> afraid I might have missed something important there.

You did! What you missed is that those methods should be
implemented in the derived classes, and not the vvp_net_fun_t
class itself. The vvp_net_fun_t is used kinda like an abstract
base class.

- -- 
Steve Williams                "The woods are lovely, dark and deep.
steve at icarus.com           But I have promises to keep,
http://www.icarus.com         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlbHyM8ACgkQrPt1Sc2b3iliTQCfSqPTjRd1QRojbb2YlkJewdaI
LqgAn18h5rDtUy2gjgm5glUIAVfdhkC/
=evNv
-----END PGP SIGNATURE-----