[Iverilog-devel] CFLAGS not set in vvp directory

[Cary R. <cy...@ya...>]

DSteve,

There are three C files in the vvp direcdtory: draw_tt.c, libvpi.c and
vpip_format.c.

draw_tt.c is used to generate tables.cc, it uses HOSTCC and not CC. Why is
this? The compilation does not reference CFLAGS. If you compile it with
-Wall a few simple warnings are present. Should this be changes to
reference CC, use CFLAGS and clean up the warnings?

libvpi.c is a library stub and compiles fine with -Wall. It does not
reference CFLAGS. Should the Makefile creation be changed to define CFLAGS
like in the other Makefiles and then use it when compiling this file?

vpip_format.c is used to create formated strength information. Like
libvpi.c it compiles fine with -Wall, but it does reference an undefined
CFLAGS. Of the three files this one really should use a correct CFLAGS
since you may want to debug the code and you would need the -g for that to
work. As a minimum I think this one should be fixed.

For consistency I think everything should be be fixed to use CC/CFLAGS and
the warnings in draw_tt.c should be cleaned up, but there may be a reason
things should be left as is. Let me know what you think.

Cary


      ____________________________________________________________________________________
Be a better friend, newshound, and 
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ