Re: [Iverilog-devel] Snapshot today?

[Stephen W. <st...@ic...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Hmm, this could be slightly tricky.

Larry Doolittle wrote:
> On Fri, Jan 11, 2008 at 02:20:08PM -0800, Stephen Williams wrote:
>> I find myself waiting on simulations today so am looking into making
>> a devel snapshot. Are there any outstanding patches that people really
>> want to see in this snapshot? I'm in the process of going through the
>> Patches tracker to apply those already submitted patches.
> 
> Not-so-minor issue I just ran into installing on a fresh computer
> (I'm rebuilding my laptop -- Gutsy Gibbon, not that it matters).
> 
> The build rules for eval_bool.o don't include a proper include
> directory to search for _pli_types.h.
> 
> gcc -DHAVE_CVS_IDENT=1 -I. -I../../verilog/tgt-vvp/..  -DHAVE_CONFIG_H -fPIC -Wall -g -O2 -MD -c ../../verilog/tgt-vvp/eval_bool.c -o eval_bool.o
> ../../verilog/tgt-vvp/eval_bool.c:23:57: error: _pli_types.h: No such file or directory
> ../../verilog/tgt-vvp/eval_bool.c: In function `draw_number_bool64':
> ../../verilog/tgt-vvp/eval_bool.c:67: error: expected ')' before 'PLI_UINT64_FMT'
> ../../verilog/tgt-vvp/eval_bool.c:67: warning: too few arguments for format
> make[1]: *** [eval_bool.o] Error 1
> 
> I think I never hit this before because I always had a previous valid
> install, so it finds _pli_types.h from that .. but I'm not sure.
> It looks like adding -I.. will do.  <tappety-typ>  Yup, that works, I checked.

The general idea is that code generator source should not ever
peek into other Icarus Verilog source. They are supposed to be
separable. Also, although _pli_types.h is sorta public, I don't
think eval_bool.c should include it at all.

It turns out that eval_bool.c is using PLI_UINT64_FMT to match
a uint64_t; it should be using the STDMACROS from <inttypes.h>.
I've pushed a change into git. You'll need to rerun autoconf.sh
to make the configure scripts, and reconfigure for the change to
take effect. This should only be a problem on systems where the
inttypes.h header file doesn't exist.

- --
Steve Williams                "The woods are lovely, dark and deep.
steve at icarus.com           But I have promises to keep,
http://www.icarus.com         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHi6HRrPt1Sc2b3ikRAnPVAJ9BM6QUkxk+jGPXBGrhGhH1uDpRLACfeOtV
QE42kGb+Ya9ffBqGm55AeAY=
=Ekau
-----END PGP SIGNATURE-----