Menu
▾
▴
iverilog-devel
|
From: Maciej S. <mac...@ce...> - 2016-03-07 16:39:42
Attachments:
signature.asc
|
Hi, There is a new branch [1] that contains a few fixes for vhdlpp and one for ivl. There are also tests to support the introduced changes [2]. Again, it would be great if you could have a look at the ivl related commit [3]. When I executed a certain test [4], it seemed to me that slices were not correctly computed in a few cases. It should be fixed now. The new pull request includes the previous one, so I have canceled the old request. Regards, Orson 1. https://github.com/steveicarus/iverilog/pull/92 2. https://github.com/orsonmmz/ivtest/tree/vhdlpp_fixes_test 3. https://github.com/orsonmmz/iverilog/commit/de775975e8d846c2a591a7889dd26c96b76acbc3 4. https://github.com/orsonmmz/ivtest/blob/b926f97f9b1ece5d8a09a9be6fd4b33407c67d59/ivltests/array_packed_2d.v |
|
From: Stephen W. <st...@ic...> - 2016-03-07 17:20:32
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This pull seems to have created a few new regressoins in VHDL code. These fail now. Are there ivtest changes that you need to push? steve@icarus:~/icarus/eda/ivtest> diff regression_report-devel.txt regression_report.txt 2089c2089 < vhdl_string_lim: Passed. - --- > vhdl_string_lim: ==> Failed - running iverilog. 2100c2100 < vhdl_textio_read: Passed. - --- > vhdl_textio_read: ==> Failed - running iverilog. 2115c2115 < vhdl_while: Passed. - --- > vhdl_while: ==> Failed - running iverilog. 2192c2192 < Total=2187, Passed=2181, Failed=6, Not Implemented=0, Expected Fail=0 - --- > Total=2187, Passed=2178, Failed=9, Not Implemented=0, Expected > Fail=0 On 03/07/2016 08:39 AM, Maciej Sumiński wrote: > Hi, > > There is a new branch [1] that contains a few fixes for vhdlpp and > one for ivl. There are also tests to support the introduced changes > [2]. > > Again, it would be great if you could have a look at the ivl > related commit [3]. When I executed a certain test [4], it seemed > to me that slices were not correctly computed in a few cases. It > should be fixed now. > > The new pull request includes the previous one, so I have canceled > the old request. > > Regards, Orson > > 1. https://github.com/steveicarus/iverilog/pull/92 2. > https://github.com/orsonmmz/ivtest/tree/vhdlpp_fixes_test 3. > https://github.com/orsonmmz/iverilog/commit/de775975e8d846c2a591a7889dd26c96b76acbc3 > > 4. > https://github.com/orsonmmz/ivtest/blob/b926f97f9b1ece5d8a09a9be6fd4b33407c67d59/ivltests/array_packed_2d.v > > - -- Steve Williams "The woods are lovely, dark and deep. steve at icarus.com But I have promises to keep, http://www.icarus.com and lines to code before I sleep, http://www.picturel.com And lines to code before I sleep." -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlbduFcACgkQrPt1Sc2b3ilrAQCgupDe1BoNH8kZz6giaSphmBHO 6HcAoLkQuSgEglqtpeHG1TtEarkR+gUt =igHT -----END PGP SIGNATURE----- |
|
From: Maciej S. <mac...@ce...> - 2016-03-08 08:52:49
Attachments:
signature.asc
|
Yes, I had to change the tests. The reason is, now variables are emitted in corresponding process scopes, so there is no direct access to them from another module and these tests relied on that (i.e. I cannot check 'if(dut.variable == 42)' anymore). I will push the changes to the test repository soon. Regards, Orson On 03/07/2016 06:20 PM, Stephen Williams wrote: > > > This pull seems to have created a few new regressoins in > VHDL code. These fail now. Are there ivtest changes that > you need to push? > > > steve@icarus:~/icarus/eda/ivtest> diff regression_report-devel.txt > regression_report.txt > 2089c2089 > < vhdl_string_lim: Passed. > --- >> vhdl_string_lim: ==> Failed - running iverilog. > 2100c2100 > < vhdl_textio_read: Passed. > --- >> vhdl_textio_read: ==> Failed - running iverilog. > 2115c2115 > < vhdl_while: Passed. > --- >> vhdl_while: ==> Failed - running iverilog. > 2192c2192 > < Total=2187, Passed=2181, Failed=6, Not Implemented=0, Expected Fail=0 > --- >> Total=2187, Passed=2178, Failed=9, Not Implemented=0, Expected >> Fail=0 > > > On 03/07/2016 08:39 AM, Maciej Sumiński wrote: >> Hi, > >> There is a new branch [1] that contains a few fixes for vhdlpp and >> one for ivl. There are also tests to support the introduced changes >> [2]. > >> Again, it would be great if you could have a look at the ivl >> related commit [3]. When I executed a certain test [4], it seemed >> to me that slices were not correctly computed in a few cases. It >> should be fixed now. > >> The new pull request includes the previous one, so I have canceled >> the old request. > >> Regards, Orson > >> 1. https://github.com/steveicarus/iverilog/pull/92 2. >> https://github.com/orsonmmz/ivtest/tree/vhdlpp_fixes_test 3. >> https://github.com/orsonmmz/iverilog/commit/de775975e8d846c2a591a7889dd26c96b76acbc3 > > > 4. >> https://github.com/orsonmmz/ivtest/blob/b926f97f9b1ece5d8a09a9be6fd4b33407c67d59/ivltests/array_packed_2d.v > > > |
|
From: Martin W. <mai...@ma...> - 2016-03-08 20:56:27
|
This pull has also introduced a number of shadow warnings, e.g.
g++ -I. -I.. -I../../source/vhdlpp -I../../source/vhdlpp/.. -I../../source/vhdlpp/../libmisc
-DHAVE_CONFIG_H -Wall -Wextra -Wshadow -g -O2 -MD -c ../../source/vhdlpp/main.cc -o main.o
In file included from ../../source/vhdlpp/std_funcs.h:23:0,
from ../../source/vhdlpp/main.cc:79:
../../source/vhdlpp/subprogram.h: In constructor
SubprogramStdHeader::SubprogramStdHeader(perm_string, std::list<InterfacePort*>*, const VType*):
../../source/vhdlpp/subprogram.h:150:40: warning: declaration of name shadows a member of 'this'
[-Wshadow]
const VType*return_type) :
|
|
From: Maciej S. <mac...@ce...> - 2016-03-09 10:32:56
|
Thank you Martin. I do not get these warnings with gcc 5.3.0, it seems that only older versions care about the problem. Please see the attached patch. Regards, Orson On 03/08/2016 09:56 PM, Martin Whitaker wrote: > This pull has also introduced a number of shadow warnings, e.g. > > g++ -I. -I.. -I../../source/vhdlpp -I../../source/vhdlpp/.. -I../../source/vhdlpp/../libmisc > -DHAVE_CONFIG_H -Wall -Wextra -Wshadow -g -O2 -MD -c ../../source/vhdlpp/main.cc -o main.o > In file included from ../../source/vhdlpp/std_funcs.h:23:0, > from ../../source/vhdlpp/main.cc:79: > ../../source/vhdlpp/subprogram.h: In constructor > 'SubprogramStdHeader::SubprogramStdHeader(perm_string, std::list<InterfacePort*>*, const VType*)': > ../../source/vhdlpp/subprogram.h:150:40: warning: declaration of 'name' shadows a member of 'this' > [-Wshadow] > const VType*return_type) : > > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://makebettercode.com/inteldaal-eval > _______________________________________________ > Iverilog-devel mailing list > Ive...@li... > https://lists.sourceforge.net/lists/listinfo/iverilog-devel > |
|
From: Martin W. <mai...@ma...> - 2016-03-10 19:28:52
|
Thanks Orson. It is indeed a problem with older versons of gcc. Before pushing your patch, I'd like
to ask if the other developers think it is worth pandering to this. The issue arises when you have
something like:
class c {
public:
void set_i(int i);
int i();
...
}
Older versions of GCC (< 5.0) complain that the local variable 'i' in 'set_i' shadows the function
'i'. Newer versions permit it.
There are a couple of remaining warnings of this nature in vvp (not of Orson's making).
Martin
P.S. When I run the test suite, the vhdl_multidim_array test is failing. Is this expected?
Maciej Sumiński wrote:
> Thank you Martin. I do not get these warnings with gcc 5.3.0, it seems
> that only older versions care about the problem. Please see the attached
> patch.
>
> Regards,
> Orson
>
> On 03/08/2016 09:56 PM, Martin Whitaker wrote:
>> This pull has also introduced a number of shadow warnings, e.g.
>>
>> g++ -I. -I.. -I../../source/vhdlpp -I../../source/vhdlpp/.. -I../../source/vhdlpp/../libmisc
>> -DHAVE_CONFIG_H -Wall -Wextra -Wshadow -g -O2 -MD -c ../../source/vhdlpp/main.cc -o main.o
>> In file included from ../../source/vhdlpp/std_funcs.h:23:0,
>> from ../../source/vhdlpp/main.cc:79:
>> ../../source/vhdlpp/subprogram.h: In constructor
>> 'SubprogramStdHeader::SubprogramStdHeader(perm_string, std::list<InterfacePort*>*, const VType*)':
>> ../../source/vhdlpp/subprogram.h:150:40: warning: declaration of 'name' shadows a member of 'this'
>> [-Wshadow]
>> const VType*return_type) :
>>
>>
>> ------------------------------------------------------------------------------
>> Transform Data into Opportunity.
>> Accelerate data analysis in your applications with
>> Intel Data Analytics Acceleration Library.
>> Click to learn more.
>> http://makebettercode.com/inteldaal-eval
>> _______________________________________________
>> Iverilog-devel mailing list
>> Ive...@li...
>> https://lists.sourceforge.net/lists/listinfo/iverilog-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
>
>
>
> _______________________________________________
> Iverilog-devel mailing list
> Ive...@li...
> https://lists.sourceforge.net/lists/listinfo/iverilog-devel
>
|
|
From: Maciej S. <mac...@ce...> - 2016-03-11 07:57:48
Attachments:
signature.asc
|
I am sorry for not mentioning it, but vhdl_multidim_array test is
expected to fail at the moment. It relies on a ivl feature that is not
available yet. Should I disable it?
Regards,
Orson
On 03/10/2016 08:28 PM, Martin Whitaker wrote:
> Thanks Orson. It is indeed a problem with older versons of gcc. Before pushing your patch, I'd like
> to ask if the other developers think it is worth pandering to this. The issue arises when you have
> something like:
>
> class c {
> public:
> void set_i(int i);
> int i();
> ...
> }
>
> Older versions of GCC (< 5.0) complain that the local variable 'i' in 'set_i' shadows the function
> 'i'. Newer versions permit it.
>
> There are a couple of remaining warnings of this nature in vvp (not of Orson's making).
>
> Martin
>
> P.S. When I run the test suite, the vhdl_multidim_array test is failing. Is this expected?
>
> Maciej Sumiński wrote:
>> Thank you Martin. I do not get these warnings with gcc 5.3.0, it seems
>> that only older versions care about the problem. Please see the attached
>> patch.
>>
>> Regards,
>> Orson
>>
>> On 03/08/2016 09:56 PM, Martin Whitaker wrote:
>>> This pull has also introduced a number of shadow warnings, e.g.
>>>
>>> g++ -I. -I.. -I../../source/vhdlpp -I../../source/vhdlpp/.. -I../../source/vhdlpp/../libmisc
>>> -DHAVE_CONFIG_H -Wall -Wextra -Wshadow -g -O2 -MD -c ../../source/vhdlpp/main.cc -o main.o
>>> In file included from ../../source/vhdlpp/std_funcs.h:23:0,
>>> from ../../source/vhdlpp/main.cc:79:
>>> ../../source/vhdlpp/subprogram.h: In constructor
>>> 'SubprogramStdHeader::SubprogramStdHeader(perm_string, std::list<InterfacePort*>*, const VType*)':
>>> ../../source/vhdlpp/subprogram.h:150:40: warning: declaration of 'name' shadows a member of 'this'
>>> [-Wshadow]
>>> const VType*return_type) :
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Transform Data into Opportunity.
>>> Accelerate data analysis in your applications with
>>> Intel Data Analytics Acceleration Library.
>>> Click to learn more.
>>> http://makebettercode.com/inteldaal-eval
>>> _______________________________________________
>>> Iverilog-devel mailing list
>>> Ive...@li...
>>> https://lists.sourceforge.net/lists/listinfo/iverilog-devel
>>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Transform Data into Opportunity.
>> Accelerate data analysis in your applications with
>> Intel Data Analytics Acceleration Library.
>> Click to learn more.
>> http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
>>
>>
>>
>> _______________________________________________
>> Iverilog-devel mailing list
>> Ive...@li...
>> https://lists.sourceforge.net/lists/listinfo/iverilog-devel
>>
>
>
> ------------------------------------------------------------------------------
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
> _______________________________________________
> Iverilog-devel mailing list
> Ive...@li...
> https://lists.sourceforge.net/lists/listinfo/iverilog-devel
>
|
|
From: Martin W. <mai...@ma...> - 2016-03-12 23:47:49
|
Maciej Sumiński wrote: > I am sorry for not mentioning it, but vhdl_multidim_array test is > expected to fail at the moment. It relies on a ivl feature that is not > available yet. Should I disable it? > I think it's OK to leave it in. I've updated the expected results to show it failing. The new/changed VHDL tests exposed a few issues in the vlog95 regression tests. I've fixed the majority of these, and updated regress-vlog95.list to reflect everything I couldn't fix. There are still quite a few failures in the v10 regression tests as a result of the VHDL test changes. I've run out of time to look at these. Martin |
|
From: Cary R. <cy...@ya...> - 2016-03-13 14:56:48
|
I think we should strive to be compile clean on older version of gcc/clang, specifically the stable Ubuntu releases, etc. To me something that compiles without a bunch of warnings is an indication of the care and thought put into the code (i.e. if the developers were willing to put in the effort to get a clean compile they are likely thorough enough to have thought full and tested code). Maybe this i just a personal bias, but my vote is for clean code.
Cary
On Saturday, March 12, 2016 3:48 PM, Martin Whitaker <mai...@ma...> wrote:
Maciej Sumiński wrote:
> I am sorry for not mentioning it, but vhdl_multidim_array test is
> expected to fail at the moment. It relies on a ivl feature that is not
> available yet. Should I disable it?
>
I think it's OK to leave it in. I've updated the expected results to show it failing.
The new/changed VHDL tests exposed a few issues in the vlog95 regression tests. I've fixed the
majority of these, and updated regress-vlog95.list to reflect everything I couldn't fix.
There are still quite a few failures in the v10 regression tests as a result of the VHDL test
changes. I've run out of time to look at these.
Martin
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
_______________________________________________
Iverilog-devel mailing list
Ive...@li...
https://lists.sourceforge.net/lists/listinfo/iverilog-devel
|
Thanks for helping keep SourceForge clean.
X