Menu
▾
▴
iverilog-devel
|
From: Maciej S. <mac...@ce...> - 2015-03-27 20:18:11
Attachments:
signature.asc
|
Hi Steve, This time I have just a minor update that brings support for using function calls in concatenations and a few fixes [1,2]. I would be grateful if you could review at least the two commits related to ivl. Nothing is broken according to the test suite (moreover, the changes seem to fix some problems), but I am not always sure if I put solutions in the right place. Thank you in advance. Regards, Orson 1. https://github.com/steveicarus/iverilog/pull/56 2. https://github.com/orsonmmz/ivtest/tree/expfunc_test |
|
From: Maciej S. <mac...@ce...> - 2016-02-15 16:29:59
Attachments:
signature.asc
|
Hi, I have just created a new pull request [1] supported by unit tests [2]. Changes: = vhdlpp - support for basic loops (loop .. end loop) - subtype declarations - initial support for CHARACTER enums (LF & CR for now) - system functions: now, shift_left, shift_right - limited support for final wait statement - concurrent assertion statements - delayed assignment statements - conditional assignments without the ending 'else' statement - subprogram overloading (support for multiple functions with the same name, but different parameters types) - multidimensional arrays, only on the vhdlpp side (i.e. VHDL code is translated but cannnot be executed yet) - a bunch of fixes = ivl - part selection in multidimensional packed ports assignment = vvp - implemented vvp_net_fun_t::recv_vec4_pv() It would be great if the ivl & vvp changes were reviewed more carefully. recv_vec4_pv() seemed suspiciously simple, and I am afraid I might have missed something important there. Code responsible for part selection in multidimensional packed ports assignment is based on the code I have seen in elab_expr.cc (PEIdent::elaborate_expr_net_part_). Regards, Orson 1. https://github.com/steveicarus/iverilog/pull/90 2. https://github.com/orsonmmz/ivtest/tree/subp_overload_test |
|
From: Stephen W. <st...@ic...> - 2016-02-20 02:00:56
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/15/2016 08:29 AM, Maciej Sumiński wrote: > It would be great if the ivl & vvp changes were reviewed more > carefully. recv_vec4_pv() seemed suspiciously simple, and I am > afraid I might have missed something important there. You did! What you missed is that those methods should be implemented in the derived classes, and not the vvp_net_fun_t class itself. The vvp_net_fun_t is used kinda like an abstract base class. - -- Steve Williams "The woods are lovely, dark and deep. steve at icarus.com But I have promises to keep, http://www.icarus.com and lines to code before I sleep, http://www.picturel.com And lines to code before I sleep." -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlbHyM8ACgkQrPt1Sc2b3iliTQCfSqPTjRd1QRojbb2YlkJewdaI LqgAn18h5rDtUy2gjgm5glUIAVfdhkC/ =evNv -----END PGP SIGNATURE----- |
|
From: Maciej S. <mac...@ce...> - 2016-02-24 16:02:23
Attachments:
signature.asc
|
On 02/20/2016 03:00 AM, Stephen Williams wrote: > On 02/15/2016 08:29 AM, Maciej Sumiński wrote: >> It would be great if the ivl & vvp changes were reviewed more >> carefully. recv_vec4_pv() seemed suspiciously simple, and I am >> afraid I might have missed something important there. > > You did! What you missed is that those methods should be > implemented in the derived classes, and not the vvp_net_fun_t > class itself. The vvp_net_fun_t is used kinda like an abstract > base class. Thank you for the notice. I have already fixed it and rebased the branch. I am still not sure about the semantics though. It works for me, and there is a test [1] that demonstrates what I was trying to achieve, but I do not know if it covers all possible cases. Regards, Orson 1. https://github.com/orsonmmz/ivtest/commit/bf46c7d1eaddeec88a0c21a6208a2cd3a51b85d1 |
|
From: Stephen W. <st...@ic...> - 2016-02-24 16:14:47
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thanks, I'll take a look and merge it as soon as I can. (Busy day today.) On 02/24/2016 07:46 AM, Maciej Sumiński wrote: > On 02/20/2016 03:00 AM, Stephen Williams wrote: >> On 02/15/2016 08:29 AM, Maciej Sumiński wrote: >>> It would be great if the ivl & vvp changes were reviewed more >>> carefully. recv_vec4_pv() seemed suspiciously simple, and I am >>> afraid I might have missed something important there. >> >> You did! What you missed is that those methods should be >> implemented in the derived classes, and not the vvp_net_fun_t >> class itself. The vvp_net_fun_t is used kinda like an abstract >> base class. > > Thank you for the notice. I have already fixed it and rebased the > branch. > > I am still not sure about the semantics though. It works for me, > and there is a test [1] that demonstrates what I was trying to > achieve, but I do not know if it covers all possible cases. > > Regards, Orson > > 1. > https://github.com/orsonmmz/ivtest/commit/bf46c7d1eaddeec88a0c21a6208a2cd3a51b85d1 > > - -- Steve Williams "The woods are lovely, dark and deep. steve at icarus.com But I have promises to keep, http://www.icarus.com and lines to code before I sleep, http://www.picturel.com And lines to code before I sleep." -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlbN1u4ACgkQrPt1Sc2b3ik8GACgk5CHibXMWIFvY4vZPmcftj84 dkgAniRtGIel5YIsYf8Zg9g/D0oX4NEJ =Ir0E -----END PGP SIGNATURE----- |
|
From: Stephen W. <st...@ic...> - 2015-03-27 20:27:08
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'll look at it fairly promptly. Thanks, On 03/27/2015 01:17 PM, Maciej Sumiński wrote: > Hi Steve, > > This time I have just a minor update that brings support for using > function calls in concatenations and a few fixes [1,2]. > > I would be grateful if you could review at least the two commits > related to ivl. Nothing is broken according to the test suite > (moreover, the changes seem to fix some problems), but I am not > always sure if I put solutions in the right place. Thank you in > advance. > > Regards, Orson > > 1. https://github.com/steveicarus/iverilog/pull/56 2. > https://github.com/orsonmmz/ivtest/tree/expfunc_test > - -- Steve Williams "The woods are lovely, dark and deep. steve at icarus.com But I have promises to keep, http://www.icarus.com and lines to code before I sleep, http://www.picturel.com And lines to code before I sleep." -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlUVvRMACgkQrPt1Sc2b3inXGACfZrhI2C/dVEjIohcQLE6W5r6L 9hQAnj0j6Y3dFJb0g6ZJ3/HSANfBSExN =iMEN -----END PGP SIGNATURE----- |
Thanks for helping keep SourceForge clean.
X