Menu

#969 display.cc:85: bad assert

v0.9
closed-fixed
nobody
None
5
2015-02-26
2015-02-24
dcb
No

[display.cc:85]: (style) Same expression on both sides of '&&'.

Source code is

assert(isdigit(p) && isdigit((p+1)) && isdigit(*(p+1)));

I suspect

assert(isdigit(p) && isdigit((p+1)) && isdigit(*(p+2)));

would be better code.

Discussion

  • Cary R.

    Cary R. - 2015-02-26
    • status: open --> closed-fixed
    • Group: devel --> v0.9
     
  • Cary R.

    Cary R. - 2015-02-26

    It took me a bit to find this. It is actually in V0.9 not development. In development this code was moved to a different file and I verified that development is using *(p+2). I have updated V0.9 in git.

     

Log in to post a comment.