The missing module-projects/downloadAttachment definition is just the tip of the iceberg.
Some discoveries that I found:
It should point to /servlets/AttachmentDownloadController instead of module-projects/downloadAttachment
AttachmentDownloadController is a plain servlet. Some keys are not synchronized with the rest of the code. (It still uses the "user" key instead of Constants.USER_KEY
There are some code duplication between GenericController and ItrackerBaseAction
There seems to be some wrong logic inside View rights. (Need to confirm this)
It seems to me that the attachment is not properly saved in the first place (Need to confirm this)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@deprecated Use org.itracker.web.actions.admin.attachment.DownloadAttachmentAction instead.
*/
public class AttachmentDownloadController extends GenericController {
public AttachmentDownloadController() {
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
And that is wrong. You can not forward to a servlet. You can only forward to an Action, Tile, or URI (a file / jsp in the Web folder) - according to my IDE. I guess we have to programme an Action "AttachmentDownload" and then somehow redirect to the Servlet. (but why do we need a Servlet for this anyway?).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=264705
Originator: NO
The missing module-projects/downloadAttachment definition is just the tip of the iceberg.
Some discoveries that I found:
Logged In: YES
user_id=1008661
Originator: NO
That comment I found is maybe interesting...
/**
@deprecated Use org.itracker.web.actions.admin.attachment.DownloadAttachmentAction instead.
*/
public class AttachmentDownloadController extends GenericController {
public AttachmentDownloadController() {
Logged In: YES
user_id=1008661
Originator: NO
I think that currently we have a forward in struts-config.xml
<forward name="downloadattachment" path="/servlets/AttachmentDownloadController"></forward>
And that is wrong. You can not forward to a servlet. You can only forward to an Action, Tile, or URI (a file / jsp in the Web folder) - according to my IDE. I guess we have to programme an Action "AttachmentDownload" and then somehow redirect to the Servlet. (but why do we need a Servlet for this anyway?).
Logged In: YES
user_id=1008661
Originator: NO
This seems to be fixed...