#224 Explicit instantiation of templates causes build failure on ARM architectures

[Kumar Appaiah]

The explicit definition of the Array<doppler_spectrum> and Array<fading_generator*> templated elements results in the typeinfo being duplicated in a non-weak way (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=608029 for more details).</fading_generator*></doppler_spectrum>

Attached is a simple patch that just restricts those definitions to the Windows case.

[Bogdan Cristea]

committed changes into master

[Kumar Appaiah]

Thanks. This bug can be closed now.

P. S. It looks like you've edited channel.h and saved it in a Unix like format, which is why the commitdiff on the git log has the full file…

[Bogdan Cristea]

yes, this should be the default format, your patch introduced to additional spaces

[Kumar Appaiah]

I see. Sorry for the trouble. The reason why I did this is because I wanted to stay consistent with the format. For instance:

# git checkout 36046522c770f496efeaf6c0e9f9e115d9abd032
# file ./itpp/comm/channel.h 
./itpp/comm/channel.h: LaTeX document, ASCII text, with CRLF line terminators
# git checkout master 
Previous HEAD position was 3604652... corrected multilateration tests
Switched to branch 'master'
# file ./itpp/comm/channel.h 
./itpp/comm/channel.h: LaTeX document, ASCII text

In other words, the file in the repository (36046 and earlier) was in the MS-DOS format, so my patch should also have had it in the same format. But the latest commit has converted the full file to the Unix format. If, for future patches, you prefer such complete file conversion, please let me know and I can do it.

Thanks!

[Bogdan Cristea]

yes, unix format is preferred and also the file should be formatted with astyle following the options file found in extras folder