Menu

Approval process automation: Approval by Team not working

DaveHeart
2023-09-04
2023-09-12
  • DaveHeart

    DaveHeart - 2023-09-04

    Hello,
    I'm using combodo-approval-process-automation/2.2.1. In my approval rule the query returns a team. The team is notified but when the user logs in and opens the ticket, he can't approve/reject the ticket.

    As a workaround I rewrote my OQL to return the persons in the team. The problem: If the person is on holiday or ill, adding other people to the team has no effect after the approval is started.

    Looking at the documentation it says the query can return teams but looking at the code it looks like it has to be persons (or a subclass).

    Can you help me with the problem?

     
  • Vincent @ Combodo

    Hi Dave,
    The documentation seems to be wrong, it can only be person and targeted approvers are computed once when reaching the waiting approval state.
    For handling approvers in vacation, have you looked at the Substitutes possibility?

     
  • DaveHeart

    DaveHeart - 2023-09-04

    Hi Vincent,
    Thanks for the quick answer. Substitutes a triggered after a delay. I would need it to be triggered after a person is added to a team.

    But thank you for your help.

     
  • Vincent @ Combodo

    There is no approvers "recomputation" entry point on the approval process.
    The approvers are stored in the Ticket in some json internal structure just before notifying them and never recomputed after.
    So you won't be able to change the list of approvers on the fly.
    To check if you are allowed to approve a given UR, the mechanism doesn't check if you are part of a team which would be allowed, it's not really a safe process, because any one allowed to edit team members could then approve Request outside of their responsibility

     
    👍
    1
  • DaveHeart

    DaveHeart - 2023-09-12

    Thanks for the info, then I have to rethink the process. :)

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.