[itom-discussions] Pull request created

[dan n. <dne...@ya...>]

 Hi Marc,
OK, I think I got it right this time. The pull request is created. I forked itom/plugins to a new repository, https://bitbucket.org/dnessett/itom-plugins/src/master/, pulled all of the tags and branches from itom/plugins to my local repository and then pushed all branches to the new repository (see https://gist.github.com/niksumeiko/8972566). For some reason I didn't have the opportunity to nominate reviewers (maybe I missed something). I assume you can add yourself as a reviewer. If not let me know how to add reviewers to an existing pull request and I will do that.
Regards,
Dan

    On Sunday, August 25, 2019, 1:08:58 PM PDT, Marc Gronle <mar...@it...> wrote:  
 
 Hi Dan,
it seems that you did not start your dnessett plugin repository as fork of the itom/plugins-repository. I don't think that there is an easy option to create a pull request without having forked this
repository. Therefore bitbucket is not able to see the connection between both repositories. I don't know an option to create a pull request in this situation. I can only manually merge
the two branches together or you have to create a fork (go to the itom/plugins bitbucket website and click the fork button behind the plus-button in the blue menu bar on the left side),
and create a new branch (under dnessett). Then you can re-push all your modifications to this merge and create the pull request to the itom/plugins repository.
CheersMarc

Am So., 25. Aug. 2019 um 20:47 Uhr schrieb dan nessett <dne...@ya...>:

 Hi Marc,
The destination repository itom/plugins does not appear in the pull down menu. The only repository that can be selected is dnessett/plugins. I even tried to do a pull request on dnessett/plugins/master, but again there is no way to select itom/plugins as the repository.
Is there another way to create the pull request?
Regards,
Dan
    On Sunday, August 25, 2019, 9:22:40 AM PDT, Marc Gronle <mar...@it...> wrote:  
 
 Hi Dan,
thanks for the pull request. I guess, that you made the pull request to merge from dnessett/niDAQmx-linux to dnessett/master. 

However you should make the pull request from dnessett/niDAQmx-linux to itom/plugins/master.If you click the "Create pull request" button on the bitbucket webpage, you should see two dropdown boxes as destination.The upper dropdown box indicates the repository. Do you see something like itom/plugins there? If yes, choose this.The bottom dropdown box indicates the branch, where you would like to have you branch merged in. This should be master.
Regards,Marc

Am Sa., 24. Aug. 2019 um 00:35 Uhr schrieb dan nessett <dne...@ya...>:

Hi Marc,
I created the pull request and listed you as reviewer. I am not sure I did it correctly, I may have created the pull request from niDAQmx-linux on my repository to master on my repository. If so, I need help to figure out how to make the pull request from niDAQmx-linux on my repository to master on the itom/plugins repository.
Regards,
Dan