Re: [Patch] Add OSX Keychain support

[Oliver R. <oli...@gm...>]

- found and removed the TAB
- removed the silent Keychain lookup entirely
- PassCmd is run even if if the Keychain lookup is successful
- removed check in configure.ac

Cheerio
  OR

On Wed, 13 Mar 2019 at 12:32, Oswald Buddenhagen
<osw...@gm...> wrote:
>
> On Mon, Mar 11, 2019 at 08:55:05PM +0100, Oliver Runge wrote:
> > I've addressed:
> > - TABs instead of spaces
> >
> there is still one obvious tab glitch (i guess you use tab size 2 or
> something ...)
>
> > - bail out if the lookup based on explicit configuration fails, indeed
> > much better
> >
> you're still unconditionally using the default credentials, which i
> don't like in general. also, you're completely breaking the logic for
> (re-)querying the password with PassCmd.
>
> i'm not sure the default account should get any magic treatment (say,
> explicitly empty strings) at all - it's probably better to just mention
> it in the docu of the new options.
>
> the configure check is certainly pointless, because this is a system
> component which has been there for quite some versions. just evaluate
> the command line switch, defaulting to on only on darwin.
>
>
>
> _______________________________________________
> isync-devel mailing list
> isy...@li...
> https://lists.sourceforge.net/lists/listinfo/isync-devel