Menu

isync Merge Request #8: Update spec file (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Keith Bowes wants to merge 1 commit from /u/zooplah/isync/ to master, 2025-05-08

I:

  1. Added the distro ID to the release (e.g. 1.5.0.rh41 for RedHat 41).
  2. Made the License tag SPDX-compliant.
  3. Added the download URL for the source.
  4. Removed the hard-coded path for BuildRoot. %{_temppath} evaluates to
    /var/tmp by default anyway.
  5. Added BuildRequires for the necessary packages to build it.
  6. Added -q to setup to appease rpmlint.
  7. Added --docdir as a configure option so that it'll build on OpenSUSE.
  8. Replaced the deprecated $RPM_BUILD_ROOT with %{buildroot}. Actually,
    the BuildRoot tag and cleaning it up are deprecated too (rpmbuild
    does it automatically), but rpmlint complains if you don't use them.

I didn't however remove Packager, even though rpmlint complains about
it.

Commit Date  
[5c486b] (update-spec) by Keith Bowes Keith Bowes

Updated isync.spec.in

1. Added the distro ID to the release (e.g. 1.5.0.rh41 for RedHat 41).
2. Made the License tag SPDX-compliant.
3. Added the download URL for the source.
4. Removed the hard-coded path for BuildRoot. %{_temppath} evaluates to
/var/tmp by default anyway.
5. Added BuildRequires for the necessary packages to build it.
6. Added -q to setup to appease rpmlint.
7. Added --docdir as a configure option so that it'll build on OpenSUSE.
8. Replaced the deprecated $RPM_BUILD_ROOT with %{buildroot}. Actually,
the BuildRoot tag and cleaning it up are deprecated too (rpmbuild
does it automatically), but rpmlint complains if you don't use them.

I didn't however remove Packager, even though rpmlint complains about
it.

2024-08-13 04:45:04 Tree

Discussion

  • Oswald Buddenhagen

    huh, crap, this effin' system didn't actually post my comments, and now the draft is gone. :-(

     

    Last edit: Oswald Buddenhagen 2024-11-24
    • Oswald Buddenhagen

      so the upshot from what i remember:

      • please clean up the branch (squash, etc.)
      • use sensible committer info
      • the packager line is only there to distinguish it from "proper" rpms, and i don't really care

      i'll re-review it properly when i see an update.

       
  • Keith Bowes

    Keith Bowes - 2025-05-08
    • Status: open --> rejected
     

Log in to post a comment.

Auth0 Logo