Menu ▾ ▴

#1603 Enhance 'Invalid ISBN' messages

Approved
closed
Ahasuerus
None
5
2024-05-02
2024-05-02
Ahasuerus
No

Currently ISBN-13s which do not start with '978' or '979' display an "Invalid ISBN checksum" message on Publication pages. It should be changed to "Bad format", the same message that is displayed for non-numeric ISBN values and values that are not 10 or 13 characters long.

Conversely, submission review pages currently display an "Invalid ISBN format" yellow warning for properly formatted ISBNs with a back checksum. The yellow warning should be changed to "Bad Checksum".

Discussion

  • Ahasuerus

    Ahasuerus - 2024-05-02
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1,3 @@
 Currently ISBN-13s which do not start with '978' or '979' display an "Invalid ISBN checksum" message on Publication pages. It should be changed to "Bad format", the same message that is displayed for non-numeric ISBN values and values that are not 10 or 13 characters long.
+
+Conversely, submission review pages currently display an "Invalid ISBN format" yellow warning for properly formatted ISBNs with a back checksum. The yellow warning should be changed to "Bad Checksum".
     

  • Ahasuerus

    Ahasuerus - 2024-05-02
    • status: open --> closed
    • assigned_to: Ahasuerus
     

  • Ahasuerus

    Ahasuerus - 2024-05-02

    Implemented in:

    biblio/common.py
biblio/pl.py
common/isbn.py
common/viewers.py
mod/common.py

    Installed in SVN 1176 on 2024-05-02. Closing the FR.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB