Menu

#659 HTML cannot have empty unordered lists even when Editing Tools are unavailable

v1.0 (example)
closed-fixed
None
5
2017-06-15
2017-04-21
Uzume
No

We have an Editing Tools menu but they seem to be context sensative so on some pages they are empty, however, this yeilds an empty unordered list in the HTML which fails validation. To wit, this is invalid markup:

<div class="divider">
Editing Tools:
</div>
<ul class="navbar">
</ul>

I recommend just removing the unordered list markup when no Editing Tools are available (alterantively the entire menu could be removed label and all).

See also: https://validator.w3.org/check?uri=http%3A%2F%2Fwww.isfdb.org%2Fcgi-bin%2Faward_directory.cgi&charset=%28detect+automatically%29&doctype=Inline&group=0

Discussion

  • Ahasuerus

    Ahasuerus - 2017-06-15
    • status: open --> closed-fixed
    • assigned_to: Ahasuerus
     
  • Ahasuerus

    Ahasuerus - 2017-06-15

    Fixed in biblio/common.py 1.192, installed in r2017-239 on 2017-06-15. Closing.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB