Menu

#331 Remove semilcolons as field separator

v1.0 (example)
closed-fixed
None
5
2014-01-15
2013-02-11
Ahasuerus
No

At this time semicolons are used by the software internally to separate multiple web page names. This causes a significant amount of confusion due to escaping issues. We would like to eliminate semicolons as separators and use regular XML elements instead.

Discussion

  • Ahasuerus

    Ahasuerus - 2013-02-13

    Changing tracker to separate technical issues from functional FRs.

     
  • Ahasuerus

    Ahasuerus - 2013-02-13
    • labels: 1169718 -->
     
  • Uzume

    Uzume - 2013-03-08

    This currently appears to affect:
    * common/awardtypeClass.py
    * common/titleClass.py
    * common/publisherClass.py
    * common/authorClass.py
    * common/viewers.py
    * common/pubseriesClass.py
    * edit/editawardtype.py
    * mod/tv_delete.py
    * mod/tv_update.py

    It should perhaps be noted that semicolons are legal within URI and as such this is a bug that prevents us from correctly adding web links that contain semicolons. URI percent encoding could help but it not the answer as it is legal to have URIs with both escaped and nonescaped semicolons that mean different things to the server (similar to how escaped and nonescaped plus signs often do have different meanings).

     
  • Uzume

    Uzume - 2013-03-09

    This also affects author email addresses not just web addresses.

     
  • Uzume

    Uzume - 2013-03-09

    In a similar vein there seems to also be some cleanup left over from authors that are in a single string separated by plus sign.

    Also these "lists" seems to have spurious "num" counters. In Python this is not required as list objects know their length and it can be queried via len().

    Look into these symbols:
    PrintMultField

    publisher_webpages
    pub_series_webpages
    award_type_webpages
    author_emails
    author_webpages
    title_webpages

    num_authors
    title_authors
    num_subjauthors
    num_authors
    pub_authors
    num_artists
    pub_artists
    num_authors
    award_authors

     
  • Ahasuerus

    Ahasuerus - 2013-03-11

    Changing the tracker to "Bugs" since semicolons are allowed in URIs, so our software can mangle valid URIs.

     
  • Ahasuerus

    Ahasuerus - 2014-01-15
    • status: open --> closed-fixed
    • assigned_to: Ahasuerus
    • Group: --> v1.0 (example)
     
  • Ahasuerus

    Ahasuerus - 2014-01-15

    Fixed in:

    common/authorClass.py 1.11
    common/awardtypeClass.py 1.3
    common/library.py 1.35
    common/publisherClass.py 1.4
    common/pubseriesClass.py 1.4
    common/titleClass.py 1.15
    common/viewers.py 1.12
    edit/editawardtype.py 1.5
    edit/isfdblib_print.py 1.18
    edit/submitauth.py 1.17
    edit/submitawardtype.py 1.4
    edit/submitpublisher.py 1.8
    edit/submitpubseries.py 1.6
    edit/submittitle.py 1.20
    edit/tv_merge.py 1.9
    mod/tv_delete.py 1.8
    mod/tv_merge.py 1.9
    mod/tv_update.py 1.8
    

    Installed in r2014-23 on 2014-01-14. Closing.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB