ISFDB Bibliographic Tools / Bugs / #196 Return to Viewing link is displayed always

#196 Return to Viewing link is displayed always

Status: closed-fixed

Owner: Uzume

Labels: Editor Interface (89)

Priority: 5

Updated: 2013-03-13

Created: 2010-12-22

Creator: Jesse Weinstein

Private: No

In edit/isfdblib.py MakeModAndViewLinks, the line "if item_id and view_script:" appears to let through invalid values of item_id. item_id is invalid if it is the string "0", which (like all non-empty strings in Python) evaluates to true. The line should probably be changed to "if item_id != "0" and view_script:".

Discussion

Uzume - 2013-03-09

edit/isfdblib.py 1.26 committed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-03-13

assigned_to: nobody --> uzume

labels: --> Editor Interface

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-03-13

Fixed in edit/isfdblib.py 1.28, installed in r2013-61 on 2013-03-12.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous

Return to Viewing link is displayed always

Group

Searches

Help

#196 Return to Viewing link is displayed always

Discussion