Re: [Iscsitarget-devel] /proc/.../tgtcfg

[<hoo...@ya...>]

FUJITA Tomonori:
> I've been too busy to discuss this essential topic. Very sorry. Please
> wait for two weeks.

ok, i'll wait for you.
and unfortunately i dont have MS iSNS and any IP SAN box.


> About the second request, I know that there are protocol dependent
> parts in IET code. However, I've already started to fix them in my
> repository.

i'll wait for that too.


one thing for next release, there is a minor patch which usees enum
values as an array index like this. it will make handling parameters
simple, i hope. the concept was sent a few days ago in another patch.
do i refine it and send again?


Junjiro Okajima


 struct iscsi_sess_param {
+	int val[session_key_last];
+
+#define sp_initial_r2t	val[key_initial_r2t]
+#define sp_immediate_data	val[key_immediate_data]
+#define sp_max_connections	val[key_max_connections]
+#define sp_max_data_pdu_length	val[key_max_data_pdu_length]
+#define sp_max_burst_length	val[key_max_burst_length]
+#define sp_first_burst_length	val[key_first_burst_length]
+#define sp_default_wait_time	val[key_default_wait_time]
+#define sp_default_retain_time	val[key_default_retain_time]
+#define sp_max_outstanding_r2t	val[key_max_outstanding_r2t]
+#define sp_data_pdu_inorder	val[key_data_pdu_inorder]
+#define sp_data_sequence_inorder	val[key_data_sequence_inorder]
+#define sp_error_recovery_level	val[key_error_recovery_level]
+#define sp_header_digest	val[key_header_digest]
+#define sp_data_digest	val[key_data_digest]
+#define sp_ofmarker	val[key_ofmarker]
+#define sp_ifmarker	val[key_ifmarker]
+#define sp_ofmarkint	val[key_ofmarkint]
+#define sp_ifmarkint	val[key_ifmarkint]
 };

----------------------------------------------------------------------

 static void sess_param_set(struct iscsi_sess_param *param, struct iscsi_param_info *info)
 {
 	u32 *iparam = info->session_param;
+	int i;
+	for (i = 0; i < session_key_last; i++)
+		SET_PARAM(param, info, iparam, i);
 }

(and others...)