From: Martin D. <li...@md...> - 2003-10-20 20:01:15
|
On Sun, 19 Oct 2003, Noah J. Misch wrote: > This is a trivial patch against the Kconfig entry for the VLSI FIR driver to > make it depend on X86. The in-tree code guarantees that the driver will only > build on X86, and according to the comments therein no machine of another > architecture has this hardware anyway. Well, it would work with any arch, _if_ there was a way to sync the streaming pci dma buffers before giving them back to hardware. Last time I checked there was no pci_dma api call to achieve this on all platforms. For X86 however it's trivial due to cache coherency. The guy is used with X86 notebooks only - unless whoever owns the controller design decides to make some CardBus PC-Card for people with notebooks lacking IrDA-support. > Granted, no human intelligently configuring a kernel for his or her particular > system would make this mistake, but perhaps someone building a distribution > kernel would. I suggest this patch because it keeps the signal to noise ratio > for those testing allyesconfig builds low. Valid point, yes. > This patch applies to the linux-2.5 BK tree as of 0400 UTC 10/20/2003, and for > some time before that as well. Please consider for eventual inclusion. It may > be too much of a fringe case until 2.6.0 begins its stable series. Thanks, second this. Martin |