[irda-users] smc-ircc.c bug (with fix) (fwd)

[Rob M. <ro...@ja...>]

One line patch attached, hope it makes it to the list.  All the info is
below, seems like an obvious fix once you find the pm_register() call.

If anyone is interested, http://www.janerob.com/rob/ts5100/irda.html has
yet more code for turning on access to the SMC chip on a 'legacy free' (no
BIOS access to enable SIR) Toshiba Satellite 5100 laptop.

rob.

---------- Forwarded message ----------
Date: Wed, 16 Apr 2003 21:43:19 +0100
From: Jeff Snyder 
To: Rob Miller 
Subject: Re: smc-ircc.c bug (with fix)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

thanks very much for fixing this, it'll be useful to me if i ever get time to 
play with swsusp again (:

however, i'm not the maintainer for the driver.
the best way to get it into the kernel is to make a patch (use "diff -uNr 
oldfile newfile") and send it to Jean Tourrilhes or the irda-users list 
(ird...@li...)

	- Jeff Snyder

On Wednesday 16 Apr 2003 9:00 pm, Rob Miller 
wrote:ird...@li.... 
> Hi,
>
> Please if you could confirm that at least you've received this (whether or
> not you're still the maintainer), it would be useful.
>
> I have identified that smc-ircc.c (in linux kernels 2.4.20, 2.4.21-pre4,
> and 2.5.67) does not call pm_unregister(), and I think it should when the
> module is closed up.  This causes a problem for swsusp (the suspend to
> swap partition work) in that it will cause a crash when it tries to free
> system memory.
>
> I made ircc_close() look like:
>
> #ifdef MODULE
> static int __exit ircc_close(struct ircc_cb *self)
> {
>         int iobase;
>
>         IRDA_DEBUG(0, "%s()\n", __FUNCTION__);
>         ASSERT(self != NULL, return -1;);
>         iobase = self->irport->io.fir_base;
>         pm_unregister(self->pmdev);    // <<<<<---------- add this line
>         irport_close(self->irport);
>
> <snip>
>
> and now it works for me again.
>
> If you can pass this tiny fix along to the right people, or point me in
> their direction, I would be grateful.
>
> thanks,
>
> rob
>
> ro...@ja...
> http://www.janerob.com/rob/ts5100/irda.html (which I may get updated
> shortly)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+ncBsgV6z3V1UowARAmkwAKCEFkxzT42lsZCLsWJ8wZS6qlofbwCeM2Z/
4OZcUzAmj6V6dl/pE4m3Ddk=
=44xY
-----END PGP SIGNATURE-----