[Ipsec-tools-commits] [ ipsec-tools-Bugs-1516838 ] Wrong check for allocation error in nattraversal.c

[SourceForge.net <no...@so...>]

Bugs item #1516838, was opened at 2006-07-04 10:49
Message generated for change (Comment added) made by vanhu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=541482&aid=1516838&group_id=74601

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: CVS snapshot
Status: Open
Resolution: None
Priority: 5
Submitted By: Bruno Wagenseil (bwagenseil)
Assigned to: Nobody/Anonymous (nobody)
Summary: Wrong check for allocation error in nattraversal.c

Initial Comment:
Should be checked for NULL instead of not NULL?

--- nattraversal.c.orig 2006-07-04 10:43:59.430965068 +0200
+++ nattraversal.c      2006-07-04 10:44:10.446002631 +0200
@@ -385,7 +385,7 @@
        plog (LLV_ERROR, LOCATION, NULL, "Can't
allocate new KA list item\n");
        return -1;
   }
-  if ((new_addr->dst = dupsaddr(dst)) != NULL) {
+  if ((new_addr->dst = dupsaddr(dst)) == NULL) {
        racoon_free(new_addr);
        plog (LLV_ERROR, LOCATION, NULL, "Can't
allocate new KA list item\n");
        return -1;

----------------------------------------------------------------------

Comment By: VANHULLEBUS Yvan (vanhu)
Date: 2006-07-04 11:36

Message:
Logged In: YES 
user_id=105392

Commited, thanks for the patch.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=541482&aid=1516838&group_id=74601