Re: [Ipsec-tools-devel] heap corruption in setkey with priority

[Timo T. <tim...@ik...>]

Paul Moore wrote:
> spdadd ........ prio 10000 none;
>[snip]
> 
> $3.buf contains "10000 none" - yacc does not insert a \0
> 
> so the sprintf runs over
> 
> On linux it doesnt seem to do any harm (I guess the allocation unit was
> rounded up)
> 
> corrupts the heap on solaris
> 
> however this code can be replaced by one line :-
> p_priority_offset = -atol($3.buf)
> 
> I dont know where the original  code came from buts its almost a
> dailywtf candidate

Thanks. Applied.

Could you send future patches in "diff -u" format? Or at least mention the
source files and line numbers.

Thanks,
  Timo