From: <ar...@na...> - 2008-10-27 07:56:33
|
Hi, Timo Teräs <tim...@ik...> writes: > Timo Teräs wrote: >> Arnaud Ebalard wrote: >>>> I'll try to take a look at these at some time soon. I'm taking some >>>> time tomorrow for ipsec-tools and maybe I'll have time for reviewing >>>> some of these too. >>> Excellent. And thanks for the quick reply. >> >> After very quick glance: >> Patches 1,2,13-15,20 looks ok to me as-is and I'll commit them soon >> unless someone objects. > > Committed with the exception of patch 20. Thanks, Timo. > I just realized that it > is not entirely correct. While scope id is mostly not used, it is > not limited to only link-local addresses. E.g. site-local addresses > have scope id too. Site-local addresses have been deprecated (RFC 3879). They have been (kind of) replaced by Unique Local IPv6 Addresses (RFC 4193). As for the patch, I don't think it is critical to have it but IIRC, other parts of racoon's code have the exact same kind of logic. a+ |