Re: [Ipmitool-devel] ETA for ipmitool v1.8.9?

[Carol H. <ca...@us...>]

Quoting Benoit Guillon <gu...@th...>:
> Could the new PICMG commands I've sent to the list be included in the
> release too? At least, the small bugs I've seen there should be
> integrated. Just an extract of the sent ipmi_picmg.c patch that fixes
> the small bugs:
>
> @@ -192,11 +194,143 @@
> =09}
>
> =09printf("Activation Policy for FRU %x: ", atoi(argv[0]) );
> -=09printf(" %s\n",(((*(rsp->data+3))&0x01) =3D=3D 0x01)?"is locked":"is n=
ot
> locked");
> +=09printf("%s, ", (rsp->data[1] & 0x01) ? "is locked" : "is not locked");
> +=09printf("%s\n", (rsp->data[1] & 0x02) ? "deactivation locked"
> +                                       : "deactivation not locked");
> +=09return 0;
> +}
>
>
> @@ -608,11 +742,10 @@
> =09else if (!strncmp(argv[0], "policy", 6)) {
> =09=09if (argc > 2) {
> =09=09=09if (!strncmp(argv[1], "get", 3)) {
> -=09=09=09=09rc =3D ipmi_picmg_fru_activation_policy_get(intf, argc-1, &(a=
rgv[2]));
> +=09=09=09=09rc =3D ipmi_picmg_fru_activation_policy_get(intf, argc-2, &(a=
rgv[2]));
> =09=09=09}
>

Hi,

I believe I've already committed the first portion of the patch you =20
list above as per your 2/8 ipmitool-devel email (it was the #4 on my =20
list).  Please check the cvs tree and make sure it's the way you =20
wanted it.  I've just committed the second part of your patch as well.

Regarding the larger patch you sent earlier, it was also on the list I =20
put together (#12) and I'll be very happy to do the work to add the =20
patch.  However,  generally-speaking, I personally feel uneasy about =20
adding much code other than bug fixes right before a new release so =20
I'd feel better if Petter gave the go-ahead on it before I commit it =20
to 1.8.9.  Otherwise, I'll be very happy to add it right after the =20
release so folks can start using it asap.  Petter, what say you?  :-)

Thanks very much for all your work to ipmitool even better.  :-)

Carol Hebert