Re: [Ipmitool-devel] ipmievd daemon mode broken?

[Arkadiusz M. <ar...@pl...>]

On Thursday 31 August 2006 14:23, Arkadiusz Miskiewicz wrote:
> # ipmievd -I open open nodaemon
> Reading sensors...
> Waiting for events...
>
> seems working but:
> # ipmievd -I open open daemon
> #
> and it logs:
> Aug 31 14:21:34 web2 ipmievd: Reading sensors...
> Aug 31 14:21:34 web2 ipmievd: Unable to send command: Invalid argument
> Aug 31 14:21:34 web2 ipmievd: Get Device ID command failed
> Aug 31 14:21:34 web2 ipmievd: Unable to open SDR for reading
> Aug 31 14:21:34 web2 ipmievd: Unable to send command: Invalid argument
> Aug 31 14:21:34 web2 ipmievd: Get BMC Global Enables command failed
> Aug 31 14:21:34 web2 ipmievd: Could not enable event message buffer
> Aug 31 14:21:34 web2 ipmievd: Error setting up Event Interface open
>
>
> ipmievd version 1.8.8

diff -ur ipmitool-1.8.8/include/ipmitool/helper.h ipmitool-1.8.8/include/ip=
mitool/helper.h
=2D-- ipmitool-1.8.8/include/ipmitool/helper.h	2006-03-19 18:59:38.00000000=
0 +0100
+++ ipmitool-1.8.8/include/ipmitool/helper.h	2006-08-31 15:28:42.299513715 =
+0200
@@ -54,7 +54,7 @@
 void printbuf(const uint8_t * buf, int len, const char * desc);
 uint8_t ipmi_csum(uint8_t * d, int s);
 FILE * ipmi_open_file(const char * file, int rw);
=2Dvoid ipmi_start_daemon(void);
+void ipmi_start_daemon(int used_fd);
=20
 #define ipmi_open_file_read(file)	ipmi_open_file(file, 0)
 #define ipmi_open_file_write(file)	ipmi_open_file(file, 1)
Tylko w ipmitool-1.8.8/include/ipmitool: helper.h~
diff -ur ipmitool-1.8.8/lib/helper.c ipmitool-1.8.8/lib/helper.c
=2D-- ipmitool-1.8.8/lib/helper.c	2006-03-28 18:56:56.000000000 +0200
+++ ipmitool-1.8.8/lib/helper.c	2006-08-31 15:28:36.802400339 +0200
@@ -344,7 +344,7 @@
 }
=20
 void
=2Dipmi_start_daemon(void)
+ipmi_start_daemon(int used_fd)
 {
 	pid_t pid;
 	int fd;
@@ -398,7 +398,7 @@
 	chdir("/");
 	umask(0);
=20
=2D	for (fd=3D0; fd<64; fd++)
+	for (fd=3D0; fd<64 && fd !=3D used_fd ; fd++)
 		close(fd);
=20
 	open("/dev/null", O_RDWR);
diff -ur ipmitool-1.8.8/src/ipmievd.c ipmitool-1.8.8/src/ipmievd.c
=2D-- ipmitool-1.8.8/src/ipmievd.c	2006-05-02 01:22:44.000000000 +0200
+++ ipmitool-1.8.8/src/ipmievd.c	2006-08-31 15:28:09.856550116 +0200
@@ -654,7 +654,7 @@
 		FILE *fp;
 		struct stat st1;
=20
=2D		ipmi_start_daemon();
+		ipmi_start_daemon(eintf->intf->fd);
=20
 		if (lstat(pidfile, &st1) =3D=3D 0) {
 			/* already exists, erase first */



=2D-=20
Arkadiusz Mi=B6kiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/