Re: [Ipmitool-cvs] [PATCH] sel: Fix "sel time set <time>"

[Zdenek S. <zde...@gm...>]

On Wed, Mar 30, 2016 at 3:43 PM, Vasant Hegde
<heg...@li...> wrote:
> On 03/30/2016 06:52 PM, Zdenek Styblik wrote:
>>
>> Hello,
>
>
> Zdenek,
>
> Thanks for the quick review.
>

Hi Vasant,

I've followed steps in https://sourceforge.net/p/ipmitool/bugs/334/.
However, the issue has manifested itself now. I don't understand why
it wouldn't show up originally(my bad, I think) :/
I didn't test whether the patch fixes issue, though. However, we will
see and I see why it shouldn't.

>>
>> interesting and indeed. I can confirm this issue. Please, open the
>> ticket.
>
>
> Do you mean open ticket at https://sourceforge.net/p/ipmitool/bugs/new/ and
> attach patch?

Yes, please.

>
>
>>  Sending patches to mailing list equals black hole. Also, by
>> that logic, shouldn't be lt_min and gt_min part of if() block?
>
>
> I think its not required.. if both lt_min and gt_min are 0 then we don't
> have any side effect.
>

Ok.

Best regards,
Z.

> -Vasant
>