[Ipmitool-devel] [PATCH] Changing 'sel list' format for 'pre-init time stamp' events.

[Isabelle, F. <Fra...@ca...>]

Hi all.



I have a patch that changes this:

ipmitool -H 172.16.251.252  -U admin -P admin sel list
   1 | 06/11/2009 | 10:08:58 | Event Logging Disabled #0x60 | Log area reset/cleared | Asserted
   2 | Pre-Init Time-stamp   | System Event #0x03 | System Reconfigured | Asserted
   3 | Pre-Init Time-stamp   | Platform Alert #0x5d | State Asserted
   4 | Pre-Init Time-stamp   | System Event #0x03 | System Reconfigured | Deasserted

To this:

src/ipmitool -H 172.16.251.252  -U admin -P admin sel list
   1 | 06/11/2009 | 10:08:58 | Event Logging Disabled #0x60 | Log area reset/cleared | Asserted
   2 |  Pre-Init  |0000000002| System Event #0x03 | System Reconfigured | Asserted
   3 |  Pre-Init  |0000000002| Platform Alert #0x5d | State Asserted
   4 |  Pre-Init  |0000000003| System Event #0x03 | System Reconfigured | Deasserted

The purpose is to be able to correlate the events between them even though they occurred before the time was set. The 'Pre-Init Time-stamp' is defined I IPMI 2.0 spec section 37.1:

"System Event Log device up to the time that the timestamp is set with the system time value. Thus, these
timestamp values are relative to the completion of the SEL device's initialization, not January 1, 1970."

I'll commit this patch unless someone disagrees (for a good reason).

BTW I made sure '-c' still works as well.

src/ipmitool -H 172.16.251.252  -U admin -P admin sel list -c
1,06/11/2009,10:08:58,Event Logging Disabled #0x60,Log area reset/cleared,Asserted
2, Pre-Init ,0000000002,System Event #0x03,System Reconfigured,Asserted
3, Pre-Init ,0000000002,Platform Alert #0x5d,State Asserted
4, Pre-Init ,0000000003,System Event #0x03,System Reconfigured,Deasserted

$ipmitool -H 172.16.251.252  -U admin -P admin sel list -c
1,06/11/2009,10:08:58,Event Logging Disabled #0x60,Log area reset/cleared,Asserted
2,Pre-Init Time-stamp,,System Event #0x03,System Reconfigured,Asserted
3,Pre-Init Time-stamp,,Platform Alert #0x5d,State Asserted
4,Pre-Init Time-stamp,,System Event #0x03,System Reconfigured,Deasserted


Index: ipmi_sel.c
===================================================================
RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_sel.c,v
retrieving revision 1.75
diff -u -r1.75 ipmi_sel.c
--- ipmi_sel.c  27 Jan 2009 01:20:01 -0000      1.75
+++ ipmi_sel.c  11 Jun 2009 20:23:08 -0000
@@ -956,11 +956,18 @@
        if (evt->record_type < 0xe0)
        {
                if ((evt->sel_type.standard_type.timestamp < 0x20000000)||(evt->sel_type.oem_ts_type.timestamp <  0x20000000)){
-                       printf("Pre-Init Time-stamp");
+                       printf(" Pre-Init ");
+
+                       if (csv_output)
+                               printf(",");
+                       else
+                               printf(" |");
+
+                       printf("%010d", evt->sel_type.standard_type.timestamp );
                        if (csv_output)
-                               printf(",,");
+                               printf(",");
                        else
-                               printf("   | ");
+                               printf("| ");
                }
                else {
                        if (evt->record_type < 0xc0)


François Isabelle | Software Designer | Kontron Canada | T 450 437 5682 |F 450 437 8053 | E fra...@ca...