[Ipmitool-devel] ipmitool 1.8.10 - Fifth/final patch batch

[Carol H. <ca...@us...>]

Hi,

Here's the fifth and final batch of outstanding patches/issues.  Unless
someone objects, review comments and feedback should be sent within 2
weeks.

Thank you very much for your help,  :-)

Carol

----------------------------------



32)  On 5/28/08 Bernard Manjou sent in a third patch to fix an issue
with the printing of discrete sensor states:

http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200805&viewday=28

My comments:  It looks to me like the current code in
ipmi_sdr_print_discrete_state_mini() and ipmi_sdr_print_discrete_state()
is wrong and that Bernard's patch will allow these print routines to
address state bits 8-14.


33)  On June 10th (last week), Bernard Manjou sent a patch to modify
sensor, sel, and sdr routines to include sensor i2c target and lun
addresses. 

<sorry, I can't get web pointers at the moment>

My Comments:  Will follow up with comments soon.


34) On 6/11/08, Lukasz Michalski sent in a pointer to a patch he'd like
to have included:

http://sourceforge.net/tracker/index.php?func=detail&aid=1990560&group_id=95200&atid=610552


My Comments:  Will follow up with comments soon.


35) On 6/12/08, Bernard Manjou brings up the timestamp issue discussed
by he and several other folks over the past year (see #25 in my 6/16/08
third patch batch email).

My Comments:  Bernard, I agree with your interpretation of the spec and
think you could be pointing to the cause of the timestamp issues.  Would
you mind posting a patch for this so the folks who have been seeing
timestamp issues can see if it fixes things for them?  Thanks for all
your patches and help. :-) 


36)  On 6/17/08, Bernard Manjou discussed needing to add an optional
argument to ipmitool and a matching parameter to
ipmi_sdr_find_sdr_byid() to match the i2c slave address as well as the
sensor ID string and resolve an issue with current mishandling of
sensors with the same sensor IDs.

My comments:  Bernard, I think what you're proposing sounds like a good
idea.  Would you have some time to put a patch together and send it in
to us?  Thanks again. :-)


37.)  On 6/19/08, Steffen Grunewald sent in a patch to the debian/rules
file.   We'll also need to update the debian/changelog to bump the
version after committing the patch.

My comments:  Sounds good to me!