Menu

#90 reading password from file is limited to 16byte passwords

version-1.8.13
closed-fixed
None
5
2013-07-06
2012-05-01
No

Reading passwords from file, via -f switch, is limited to 16byte passwords only. This is because of hard-coded password length in ipmi_password_file_read(char * filename) in 'lib/ipmi_main.c'.

Noteworthy lines:
~~~ SNIP
char * pass = NULL;
pass = malloc(16);

if (fgets(pass, 16, fp) == NULL) {
~~~ SNIP

Suggested fix? I'm sure there can be more than one, but how about to allocate and read 20bytes instead of just 16?

Discussion

  • Zdenek Styblik

    Zdenek Styblik - 2013-03-30
    • milestone: --> version-1.8.12
     
  • Zdenek Styblik

    Zdenek Styblik - 2013-05-19
    • assigned_to: nobody --> stybla
    • status: open --> open-accepted
     
  • Zdenek Styblik

    Zdenek Styblik - 2013-05-22
    • status: open-accepted --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB