Menu

#395 Fix fru edit command for same size

version-1.8.16
closed-fixed
None
5
2015-10-26
2015-10-21
No

Hi,

there is an error with the fru edit command.
If you edit your fru with a new stringsize, everything works like it should, but if you edit a string with the same size, the content gets changed without updating the checksum, it stays the same. After digging through the code and fixing the checksum, the checksum was written where it should be.

This led to a second problem: It was the wrong checksum. Having fixed this problem, the checksum is now calculated with the right value and written to the right place.

A patch is attached

Regards
Alex

1 Attachments

Discussion

  • Zdenek Styblik

    Zdenek Styblik - 2015-10-24

    Hello Alex,

    looks good to me. Please, can you change formatting of the following to something more reasonable?

    +       for( i = 0; i < fru_section_len - 1; i ++ )
    

    Thank you,
    Z.

     

    Last edit: Zdenek Styblik 2015-10-24
  • Alexander Rube

    Alexander Rube - 2015-10-26

    Not quite sure what you expect, because it was the same style as before, but maybe this one will satisfy you?! ;)

    Greetings
    Alex

     
    • Zdenek Styblik

      Zdenek Styblik - 2015-10-26

      That's more like it, although I've added spaces around minus. I know it's exactly the same style as before and that's what I was pointing out ;)
      Thank you for the patch. It's in now.

      Z.

       
  • Zdenek Styblik

    Zdenek Styblik - 2015-10-26
    • status: open --> closed-fixed
    • assigned_to: Zdenek Styblik
     

Log in to post a comment.