#36 sdr and sensor difrent readings

[Caramarcu Costin]

ipmitool sdr -v

Sensor ID : Temp (0x1)
Entity ID : 3.1 (Processor)
Sensor Type (Analog) : Temperature
Sensor Reading : -69 (+/- 1) degrees C
Status : ok
Nominal Reading : 50.000
Normal Minimum : 11.000
Normal Maximum : 69.000
Upper critical : 90.000
Upper non-critical : 85.000
Positive Hysteresis : 1.000
Negative Hysteresis : 1.000
Minimum sensor range : Unspecified
Maximum sensor range : Unspecified
Event Message Control : Per-threshold
Readable Thresholds : unc ucr
Settable Thresholds :
Threshold Read Mask : unc ucr
Event Status : Event Messages Disabled
Assertion Events :
Event Enable : Event Messages Disabled
Assertions Enabled :

ipmitool sensor -v

Sensor ID : Temp (0x1)
Entity ID : 3.1
Sensor Type (Analog) : Temperature
Sensor Reading : READ ERROR: Device Not Present

Event Status : Event Messages Disabled
Assertion Events :
Event Enable : Event Messages Disabled
Assertions Enabled :

So sdr is reading the entity while sensor doesn't.

[Jim Mankovich]

The reason for this is that the sdr sensor reading logic does not honor the fact that the sensor returns that scanning is disabled when the sensor is read. In the sdr display routines if scanning is disabled it ignores it and displays the sensor if and only if the returned sensor reading is non-zero. I've seen this code display total nonsense for some sensors. Ignoring that scanning is disabled is incorrect from the IPMI specification perspective so I believe this code should be removed.