#339 Getciphers command help mistake

[Konstantin Franckevic]

File: /lib/ipmi_channel.c
Line 797, help message for getciphers command
*
lprintf(LOG_NOTICE, " getciphers <ipmi |="" sol=""> [channel]\n");
*</ipmi>

As I understand from this line the channel parameter isn't required. But executing the command with only one parameter lead to an error.
Line 875, getciphers command call
*
// it channel getciphers <ipmi |="" sol=""> [channel]
else if (strncmp(argv[0], "getciphers", 10) == 0)
{
if ((argc < 2) || (argc > 3) ||
(strncmp(argv[1], "ipmi", 4) && strncmp(argv[1], "sol", 3)))
printf_channel_usage();
...
*</ipmi>

As I understand from comparison of argc - there could be two parameters only - ipmi or sol and channel number.
So help message is a bit misleading.

[Zdenek Styblik]

I'm sorry, but what exactly is the issue? I'm not getting it. Help message says the first parameter can be either 'ipmi' or 'sol' and is mandatory. Channel parameter is non-mandatory. And everything seems to be in working order. I admit, error message saying what's wrong is missing, but that's about it.

Thanks!

[Konstantin Franckevic]

Oh, I'm sorry. I've just realized my stupidity(thought 2=3). You can close/delete the ticket.

[Zdenek Styblik]

Alright :)