ipmitool sdr list broken

Brought to you by: audetjm, blaism, carolh, ferlandm, and 5 others

#279 ipmitool sdr list broken

Milestone: version-1.8.14

Status: closed-fixed

Owner: Jim Mankovich

Labels: sdr (1)

Priority: 2

Updated: 2014-03-25

Created: 2013-10-18

Creator: Evgenii Terechkov

Private: No

After upgrading 1.8.12->1.8.13 (only patch applied is for CVE-2011-4339) 'ipmitool -c sdr list' returns:

===============================================================================
OS Boot Status,00h,ns,34.2,No Reading
Get SDR 0070 command failed: Timeout
Get SDR 0070 command failed: Timeout
Get SDR 0070 command failed: Timeout
Get SDR 0070 command failed: Timeout
Get SDR 0070 command failed: Timeout
===============================================================================
(first line in stdout, others in stderr)

instead of full sensors list. Оther utils builded with same libfreeipmi (isensors from openipmi package) works fine. Rollback to 1.8.12 restore normal sdr listing.

Hardware: HP DL180G6 (see attached file for more details).

1 Attachments

sysreport-20131018.tar.bz2

Discussion

Zdenek Styblik - 2013-10-18

assigned_to: Jim Mankovich
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jim Mankovich - 2013-10-18

I did see this rather concerning dmesg information from your system associated with the the ipmi system interface driver that concerns me, but I don't know if it has anything to do with your problem

Could you please run the working 1.8.12 and failing 1.8.13 sdr list command with the additional -vvvvvvv command line switch and attach the output to this bug report.

[ 0.621680] IPMI System Interface driver.
[ 0.621712] ipmi_si: Adding ACPI-specified kcs state machine
[ 0.621723] ipmi_si: Adding SMBIOS-specified kcs state machine: duplicate interface
[ 0.621742] ipmi_si: Adding ACPI-specified kcs state machine
[ 0.621746] ipmi_si: Trying ACPI-specified kcs state machine at i/o address 0xca2, slave address 0x0, irq 0
[ 0.751108] ipmi: Found new BMC (man_id: 0x00000b, prod_id: 0x0000, dev_id: 0x12)
[ 0.751117] IPMI kcs interface initialized
[ 0.751120] ipmi_si: Trying ACPI-specified kcs state machine at mem address 0x0, slave address 0x0, irq 0
[ 0.751124] Could not set up I/O space

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-18

v1.8.12 stdout

1.8.12.stdout.log

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-18

v1.8.12 stderr

1.8.12.stderr.log

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-18

v1.8.13 stdout

1.8.13.stdout.log

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-18

v1.8.13 stderr

1.8.13.stderr.log

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-18

Execution time for 1.8.12: 1m18s, for 1.8.13: 29s.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jim Mankovich - 2013-10-18

Thanks for the log files. I have a hunch what might be causing you problem, but I don't have any way to test out my hunch. Would you be willing to help me out by running some ipmitool 1.8.13 debug code for me? I could send you either patches to 1.8.13 source or a 1.8.13 TOB source tree for testing. It is really going to take some debug code to be sure I understand the problem and then I'll need to test out a fix as well.

Thanks,
Jim

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-19

Please attach debug patches against official 1.8.13 version (ipmitool-1.8.13 git tag aka 82313a422fbbc88aafe1dfa52815cca157d9013b) here. I will build and test out package with it in next week.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Jim Mankovich - 2013-10-21
  
  Here is a test and debugging patch against the released 1.8.13. Please run the failing case again on your platform with the eight -vvvvvvv and send me the output. Feel free to just send the debug output files directly to jmank@hp.com. There is no reason to put them in the bug report. If you have any problems applying the patch, let me know.
  
  Thanks for helping me debug this,
  Jim
  
  0001-Debug-HP-DL180G6-sdr-list.patch
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Zdenek Styblik - 2013-10-23
    
    Jim, it looks good to me and OK to commit. One thing, though. Please don't ...:
    
    if ( bridged_request ) {
    
    Z.
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-21

I have to do sed -i 's/-cvs//' on patch to apply it smoothly on 1.8.13. I have successfully build patched packages and will try it out asap. Stay tuned...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-22

Stdout from debug package. Note that sdr is fully populated (not truncated).

1.8.13-dbg.stdout

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-22

Stderr for debug package.

1.8.13-dbg.stderr

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jim Mankovich - 2013-10-22

Glad to hear that my patch resolved the problem. Also, the stderr debug output you captured and attached let me verify that I correctly understood what the problem was. I'm going to do some of my own testing and some more code inspection and then I'll likely submit the same fix to the ipmitool cvs repository. If you could do some more testing with what I sent you and let me know if you have any other issues with it, that would be great.

Thanks,
Jim

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jim Mankovich - 2013-10-23

Attached is a source code patch to fix this problem on the released version of ipmitool 1.8.13. I have verified that this patch can be applied to the released source code and that it does fix the reported problem. If you could please verify that the patch works correctly and let me know I would appreciate it.

Thanks,
Jim

0001-Bug-279-Fix-for-1.8.13.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Evgenii Terechkov - 2013-10-23

I have tried attached patch on some HP servers (G5 to G8), no issues so far. Thanks for your work.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Zdenek Styblik - 2013-10-23

Group: version-1.8.13 --> version-1.8.14
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Zdenek Styblik - 2013-10-26

Closing since patch has been committed into CVS.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Zdenek Styblik - 2013-10-26

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dmitry Samsonov - 2014-03-25

We had same error on another hardware with same version - 1.8.13.
Compiled version with patch 0001-Debug-HP-DL180G6-sdr-list.patch - errors gone, but sdr still doesn't show anything.
1.8.12 works correctly.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Zdenek Styblik - 2014-03-25
  
  Please, try again with Git version. If it still doesn't work, open a new ticket with reference to this one. Thanks!
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Dmitry Samsonov - 2014-03-27
    
    Git version works correctly. Thank you.
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.