#174 chassis identify

[Ales Ledvinka]

the chassis identify defaults without any arguments are undefined
identify_data.force_on may be undefined

question not answered: the default of interval 15 with no argument in description. is it standard remote behaviour when zero interval is specified?

[Ales Ledvinka]

[Zdenek Styblik]

NACK. Notice, identify_data isn't used in request if no input is given by user. I say this can be closed as 'Invalid', because there is no bug/problem to be fixed.

To answer your question about default 15s interval; this is given by IPMI specification. Yes, it should be standard remote behaviour.

[Ales Ledvinka]

except the arg == NULL, rsp != NULL, ccode>0 to hit the

if ahead of lprintf(LOG_WARNING, "Chassis may not support Force Identify On\n")

[Zdenek Styblik]

Right indeed. Suggested fix below. btw I don't think it will be undefined, but rather some random value.

struct \{
uint8\_t interval = 0;
uint8\_t force\_on = 0;
\} identify\_data;

[Ales Ledvinka]

the proposed fix + removal of the assignment past the initialization.

[Ales Ledvinka]

committed to cvs