#166 Send mark as seen

[Anonymous]

Originally created by: I3run0

Introduces the seen events handlers:

• Marks received messages as seen
• Displays in the chat when the recipient has just viewed the messages

Related to: https://github.com/supreme-gg-gg/instagram-cli/issues/156

[Anonymous]

Originally posted by: I3run0

I included the "Seen just now" in this PR. I think this feature could be a first approach to marking messages as read or unread.

[Anonymous]

Originally posted by: supreme-gg-gg

I included the "Seen just now" in this PR. I think this feature could be a first approach to marking messages as read or unread.

Yea this is an amazing feature! As a sidetone what I meant in [#156] was marking threads as seen (like how Instagram highlights your unread threads with bolded + blue dot), not message items, since I think the current way you have here is good enough for marking message as seen.

[Anonymous]

Originally posted by: I3run0

One more thing, I seemed to notice that after the realtime mark item as seen is removed, new messages arriving are no longer marked as seen as they arrive. I think you pointed this out earlier, is this also happening for you? If so perhaps you could add it back? My bad for the confusion.

Okay. I added it back

EDIT: Also pls format your code and run linter CI is failing, this should be done automatically by the pre-commit hook if you set it up properly, otherwise just running npm lint-check is fine

I executed it

[Anonymous]

Originally posted by: supreme-gg-gg

There are still some linter errors can you run npm run lint-check and make sure it passes next time:

Error: /home/runner/work/instagram-cli/instagram-cli/instagram-ts/source/client.ts: line 632, col 37, Error - Unsafe argument of type `any` assigned to a parameter of type `SeenEventMessage`. (@typescript-eslint/no-unsafe-argument)
Error: /home/runner/work/instagram-cli/instagram-cli/instagram-ts/source/client.ts: line 634, col 33, Error - '@typescript-eslint/no-unsafe-argument' rule is disabled but never reported. (eslint-comments/no-unused-disable)
Error: /home/runner/work/instagram-cli/instagram-cli/instagram-ts/source/ui/views/chat-view.tsx: line 366, col 24, Error - Prefer negative index over length minus index for `at`. (unicorn/prefer-negative-index)
Error: /home/runner/work/instagram-cli/instagram-cli/instagram-ts/source/ui/views/chat-view.tsx: line 517, col 21, Error - Curly braces are unnecessary here. (react/jsx-curly-brace-presence)

You can also pull from main again since I just disabled a few checks as well like unnecessary return.

EDIT: If npm run lint-check is not working for you and you won't mind, I can push a commit to this PR and help fix these linter issues

[Anonymous]

Originally posted by: I3run0

You can also pull from main again since I just disabled a few checks as well like unnecessary return.
EDIT: If npm run lint-check is not working for you and you won't mind, I can push a commit to this PR and help fix these linter issues

Hi, I am updated the code. Now it is supposed to pass in the lint-check

[Anonymous]

Originally posted by: I3run0

Code quality seems no to be my main skill lol 😢

[Anonymous]

Originally posted by: supreme-gg-gg

Can you update the PR description before I merge, thanks! We use that for squash msg

[Anonymous]

Originally posted by: supreme-gg-gg

Code quality seems no to be my main skill lol 😢

lol no worries, XO is a quite strict (and quite opinionated) linter lol...

[Anonymous]

Originally posted by: I3run0

Can you update the PR description before I merge, thanks! We use that for squash msg

Updated

[Anonymous]

Ticket changed by: supreme-gg-gg

• status: open --> closed