#111 [typescript] Fix client auth logic and chat view UI

[Anonymous]

Originally created by: supreme-gg-gg

Summary

• Close [#106], fixed how input bar works and threads viewport
• Refactor all client setup into useInstagramClient across the commands
• Introduces full screen using alternative screen buffer (similar to Python client)
• A lot of minor messages and threads related view improvements
• Big patch to client auth logic to fully match python implementation with session, challenge, 2FA etc.
• Prepares for image display in chat by categorizing messages
• Fix scroll up and down (j/k) in messages view and input box clearing

Note

• Bump up Ink to ^5.0.0 and any related Pastel, ink UI etc libraries, added ink-text-input (this resulted in the huge LOC)
• The challenges resolution feature with auth might not always work see https://github.com/dilame/instagram-private-api/issues/1804

Next steps for the migration

• introduce actually rendering images in chat [#104]
• migrate all chat commands (basic ones are done) [#105]

[Anonymous]

Originally posted by: endernoke

Tested that the new full screen and alt screen implementation works on bash and Kitty on Linux and cmd on windows.
@supreme-gg-gg can you test this on iterm2

[Anonymous]

Originally posted by: supreme-gg-gg

Verified to work in iterm2!!! Great work @endernoke you're the hero of Ink. I will be modifying the following and merging this today by the latest:

1. Displaying images in the CLI with ascii (since ink-image doesn't work), if this fails diabolically will revert
2. Add challenge handling logic very similarly as Python client auth
3. Tidy up every change in auth, client, refactoring, etc.

Will mark this ready for review later

[Anonymous]

Originally posted by: supreme-gg-gg

@endernoke this seems to be happening? I tried testing again and somehow it stopped working and this was what i've been seeing before, can you send a screenshot of how yours look like?

[Anonymous]

Originally posted by: supreme-gg-gg

Seems to have an issue with checkpoint resolution sometimes same as this: https://github.com/dilame/instagram-private-api/issues/1804

[Anonymous]

Originally posted by: endernoke

@supreme-gg-gg

and on a smaller screen:

I've noticed this bleeding text bug long before the fullscreen fix but thought it's because the UI is not finalized yet lol

[Anonymous]

Originally posted by: supreme-gg-gg

yup i noticed this is not fixed not sure if related to full screen but it was fine before that's why i reverted full screen, will investigate. But can still confirm the typing input is fixed!!

[Anonymous]

Originally posted by: supreme-gg-gg

@endernoke everything should be working fine on this branch now i've tested locally, might be very minor padding inconsistencies with the lists etc but we might borrow some technical credit for now lmao. the image display in chat was reverted i will add it in the next PR, this makes it easier to separate concerns for now

If this works i'll ship 2FA + resolve conflicts and merge tmr

[Anonymous]

Originally posted by: supreme-gg-gg

The threads list works 👍 on small terminal the padding is still problematic though we can put this to the backlog now send in a new PR later for more responsive UI

Also there's a glitch in the chat interface, not sure if it's introduced by this PR. Sometimes when you type in the input box the message history becomes corrupted, @supreme-gg-gg can you check if its reproducable:

@endernoke this is due to handling "k" in your input as scroll up lmao now it uses proper command handling and scroll up and down should work like python, can you test again tmr morning (i will be away) and comment here and merge it? Everything works on my side and it's safe to merge!

[Anonymous]

Originally posted by: endernoke

The threads list works 👍 on small terminal the padding is still problematic though we can put this to the backlog now send in a new PR later for more responsive UI
Also there's a glitch in the chat interface, not sure if it's introduced by this PR. Sometimes when you type in the input box the message history becomes corrupted, @supreme-gg-gg can you check if its reproducable:

@endernoke this is due to handling "k" in your input as scroll up lmao now it uses proper command handling and scroll up and down should work like python, can you test again tmr morning (i will be away) and comment here and merge it? Everything works on my side and it's safe to merge!

Oh i see lmao

lgtm also works on my side.

[Anonymous]

Ticket changed by: endernoke

• status: open --> closed