Started fixing this (rating and cast already done). To your convenience, I added all the files to SourceForge's CVS repository, so you always can get the latest development version from there e.g. via anonymous check-out (see the "Code" tab). I don't want to make a release for every single little change - so I guess this is the best way to stay up-to-date while waiting for the next release, which then is worth the name "release".
CVS code also contains already the additions made by wtf (plotline and user comments). Not sure if that was broken again now - reports welcome. Hope I find time to fix the other issues as well ASAP.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanx for the kudos - motivation is a good thing, and you got me fixing the next item :) Still not sure about the runtimes... But if someone can give a hint, I will look for that as well.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I noticed a few more errors like (I took for example the movie «Kebab Connection»):
- Sometimes «AKA»'s generates a Invalid argument supplied for foreach()
- The class retrieve only «Greek» language instead of «Greek / Turkish / German»
Hope this will help! Thanks again
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Jiv: This indeed helped (especially since you mentioned an affected movie). The function was still relying on a previous design of the IMDB site, which was staying compatible *to a certain degree*. If the movie had at least 3 AKAs, there was no error (except that the first 2 have not been used than). But with less than that, the whole thing broke.
It's fixed now in CVS - so you may want to grab a fresh coffee - ah, copy ;)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Great. Leaves us just with the runtimes() question open before the next release. Anybody used that and knows if/where this information now is to be found on IMDB (best with an example movie which really holds this information)?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I noticed another problem in a specific case. If you the the movie «The Sentinel (2006)» you'll have response that look like this in the aka :
a http-equiv="content-type" content="text/html; charset=iso-8859-1">
I tried with some other movies and the problem is intermittent. It looks like there's now some different layouts on IMDB depending on the movie your querying... It isn't homogeneous, maybe it's why there are some slight problems...
If I compare «The Sentinel (2006)» with «8½ (1963)», you'll see that there's a new photo gallery at the top of the page of The Sentinel. Hope this will help!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ooops... This bug was introduced with the last fix and only comes up when a movie has no AKA shown at all. Fixed in CVS. Thanx for great description, found it immediately this way!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
OK, took the next look on it. The pictures still seem to work (at least with the movies I tried). What still seems to be broken, is the runtimes() thing. I never used it, so I'm not sure what it is about. The code looks as if there was a list of runtimes per country (country, runtime, comment), and these data have been retrieved from the title page. However, I could not find such a listing on the title page (maybe I checked the wrong movies). Can anybody give me a hint? Everything else seems to look fine so far.
Please grab the latest version from CVS and check if I forgot something else. And if there are some hints about the runtimes(), I'll try to fix that as well.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yepp, at least now I had not to search ;) But what's wrong with "(9.0 from 19 votes)"? Not enough votes? Well, I could vote if that helps you ;) But from the numbers, it looks fine to me.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I had to look a while to find something - but to me number of votes looked OK for the entries I compared (e.g. X-Files), I cannot see the problem. If it is still present for you, please give a closer description.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ah, *now* I see what you mean (must have been some jam between my ears). Thanx for the code, applied that to the votes() function. Code now is fixed in CVS.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
i noticed the following oddity when doing a search on the term "breach" (using imdbsearch.php) (repeats for others as well)
Star Wars: Episode III - Revenge of the Sith('nm2043220',4,1) imdb page
the script seems for some reason to retrieve the movie name from the Names (Approx Matches) category on the imdb search page and appends the brackets to it.
on another note, the new release (0.8.6) has the config file extension set to .sample instead of php - is that intentional?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
> Star Wars: Episode III - Revenge of the Sith('nm2043220',4,1) imdb page
This happens on the name entries as I just found out. Easy to fix with 3 possibilities:
1) We could switch back to Sevecs original search statement (less movies, but more exact)
2) We could use the variant of moonface - and have a real huge result set (up to 1000 movies on "breach")
3) modify the izzy variant and remove the "nm=on" from the string - gives top 20 matches
For all, just look for the function "mkurl" in the class.imdb.php file - comment out the "izzy" variant, and uncomment one of the others - or modify the "izzy" variant. Then let me know which one the majority would favour, and I'll change that (or make it a new option in the config).
Ah, config. Yes, I intentionally named it .sample - so noone would accidentally overwrite his/her config while just replacing the installation with the new files from the tarball. Just name it back to .php when you are sure ;)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Since there has been no response yet, I made the decision myself *grin* Checkout from CVS, and you'll find two new configuration options:
maxresults - limit the movie search to return maximum x movies
searchvariant - which searchvariant to use (sevec, moonface or izzy)
As far as I can see, all variants return the same result set (at least with maxresults=20). But as I experienced in the past, sometimes one variant is broken while the other still work - and a few days later the broken one works again, but one other doesn't. So this way you may just switch the search variant if that happens ;)
Ah, yeah: I removed the "nm" option from the default search variant - so the error reported by Vlad should be gone.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Great - good to read that. I meanwhile also updated the info on http://www.izzysoft.de/?topic=software and the related project pages I created last week. This means, there's an online demo available now, too - and some more info on the class. Maybe I will also add some API reference next :) Ah, don't be confused about the .DE domain - it will give you English content if your browser does not prefer German over that ;) So if you want to have a look at that, you're welcome (and your feedback will be welcome, too).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
About this new layot of imdb, I use the "Also know as" feature also, but I receive that "more" too in my list. There is maybe a possibility not to appear ? For example if I search after Superman Returns, I receive for Also know as the following results:
Red Sun : , USA (fake working title)
Superman Reborn : , USA (working title)
Superman V : , USA (working title)
more: , ()
Year is not appear anymore on imdb, but that is not a problem, I removed also from my page. How about that 'more ()' ?
Thank you !
Regards,
Vali Oancea.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
IMDB updated their layout today, and several things including number of votes, picture, and cast are amongst the things that need repair.
I hope someone will fix it soon :D
Our daily change give us today... Thank you for the hint. Could you point out all things you discovered broken? I will try my best to fix them ASAP.
Started fixing this (rating and cast already done). To your convenience, I added all the files to SourceForge's CVS repository, so you always can get the latest development version from there e.g. via anonymous check-out (see the "Code" tab). I don't want to make a release for every single little change - so I guess this is the best way to stay up-to-date while waiting for the next release, which then is worth the name "release".
CVS code also contains already the additions made by wtf (plotline and user comments). Not sure if that was broken again now - reports welcome. Hope I find time to fix the other issues as well ASAP.
You're doing such an excellent job :)
Kudos!
Thanx for the kudos - motivation is a good thing, and you got me fixing the next item :) Still not sure about the runtimes... But if someone can give a hint, I will look for that as well.
Hi, thanks for the amazing work!
I noticed a few more errors like (I took for example the movie «Kebab Connection»):
- Sometimes «AKA»'s generates a Invalid argument supplied for foreach()
- The class retrieve only «Greek» language instead of «Greek / Turkish / German»
Hope this will help! Thanks again
Jiv: This indeed helped (especially since you mentioned an affected movie). The function was still relying on a previous design of the IMDB site, which was staying compatible *to a certain degree*. If the movie had at least 3 AKAs, there was no error (except that the first 2 have not been used than). But with less than that, the whole thing broke.
It's fixed now in CVS - so you may want to grab a fresh coffee - ah, copy ;)
Jiv: I forgot to mention that I cannot reproduce the languages problem here - I get all 3 languages displayed fine.
Thanks Izzy,
Don't bother about the language thing, I verified and it's my mistake...
Thanks again!
Great. Leaves us just with the runtimes() question open before the next release. Anybody used that and knows if/where this information now is to be found on IMDB (best with an example movie which really holds this information)?
I noticed another problem in a specific case. If you the the movie «The Sentinel (2006)» you'll have response that look like this in the aka :
a http-equiv="content-type" content="text/html; charset=iso-8859-1">
I tried with some other movies and the problem is intermittent. It looks like there's now some different layouts on IMDB depending on the movie your querying... It isn't homogeneous, maybe it's why there are some slight problems...
If I compare «The Sentinel (2006)» with «8½ (1963)», you'll see that there's a new photo gallery at the top of the page of The Sentinel. Hope this will help!
Ooops... This bug was introduced with the last fix and only comes up when a movie has no AKA shown at all. Fixed in CVS. Thanx for great description, found it immediately this way!
OK, took the next look on it. The pictures still seem to work (at least with the movies I tried). What still seems to be broken, is the runtimes() thing. I never used it, so I'm not sure what it is about. The code looks as if there was a list of runtimes per country (country, runtime, comment), and these data have been retrieved from the title page. However, I could not find such a listing on the title page (maybe I checked the wrong movies). Can anybody give me a hint? Everything else seems to look fine so far.
Please grab the latest version from CVS and check if I forgot something else. And if there are some hints about the runtimes(), I'll try to fix that as well.
Number of votes is b0rked for me.
What it does now:
http://tvu.org.ru/index.php?show=unverifiedseason&sid=1998
Prefetched from cache (expected)
http://tvunderground.org.ru/index.php?show=season&sid=323
Sorry the example link is bad. Here's a diff one:
http://tvu.org.ru/index.php?show=season&sid=1663
Yepp, at least now I had not to search ;) But what's wrong with "(9.0 from 19 votes)"? Not enough votes? Well, I could vote if that helps you ;) But from the numbers, it looks fine to me.
I had to look a while to find something - but to me number of votes looked OK for the entries I compared (e.g. X-Files), I cannot see the problem. If it is still present for you, please give a closer description.
2 lines to fix it:
$this->main_votes = str_replace("ratings", "http://imdb.com/title/tt".$this->imdbID."/ratings", $this->main_votes);
$this->main_votes .= "</a>";
Ah, *now* I see what you mean (must have been some jam between my ears). Thanx for the code, applied that to the votes() function. Code now is fixed in CVS.
hey,
i noticed the following oddity when doing a search on the term "breach" (using imdbsearch.php) (repeats for others as well)
Star Wars: Episode III - Revenge of the Sith('nm2043220',4,1) imdb page
the script seems for some reason to retrieve the movie name from the Names (Approx Matches) category on the imdb search page and appends the brackets to it.
on another note, the new release (0.8.6) has the config file extension set to .sample instead of php - is that intentional?
> Star Wars: Episode III - Revenge of the Sith('nm2043220',4,1) imdb page
This happens on the name entries as I just found out. Easy to fix with 3 possibilities:
1) We could switch back to Sevecs original search statement (less movies, but more exact)
2) We could use the variant of moonface - and have a real huge result set (up to 1000 movies on "breach")
3) modify the izzy variant and remove the "nm=on" from the string - gives top 20 matches
For all, just look for the function "mkurl" in the class.imdb.php file - comment out the "izzy" variant, and uncomment one of the others - or modify the "izzy" variant. Then let me know which one the majority would favour, and I'll change that (or make it a new option in the config).
Ah, config. Yes, I intentionally named it .sample - so noone would accidentally overwrite his/her config while just replacing the installation with the new files from the tarball. Just name it back to .php when you are sure ;)
Since there has been no response yet, I made the decision myself *grin* Checkout from CVS, and you'll find two new configuration options:
maxresults - limit the movie search to return maximum x movies
searchvariant - which searchvariant to use (sevec, moonface or izzy)
As far as I can see, all variants return the same result set (at least with maxresults=20). But as I experienced in the past, sometimes one variant is broken while the other still work - and a few days later the broken one works again, but one other doesn't. So this way you may just switch the search variant if that happens ;)
Ah, yeah: I removed the "nm" option from the default search variant - so the error reported by Vlad should be gone.
excellent, works fine now
thanks
Great - good to read that. I meanwhile also updated the info on http://www.izzysoft.de/?topic=software and the related project pages I created last week. This means, there's an online demo available now, too - and some more info on the class. Maybe I will also add some API reference next :) Ah, don't be confused about the .DE domain - it will give you English content if your browser does not prefer German over that ;) So if you want to have a look at that, you're welcome (and your feedback will be welcome, too).
Hello again izzy !
About this new layot of imdb, I use the "Also know as" feature also, but I receive that "more" too in my list. There is maybe a possibility not to appear ? For example if I search after Superman Returns, I receive for Also know as the following results:
Red Sun : , USA (fake working title)
Superman Reborn : , USA (working title)
Superman V : , USA (working title)
more: , ()
Year is not appear anymore on imdb, but that is not a problem, I removed also from my page. How about that 'more ()' ?
Thank you !
Regards,
Vali Oancea.