RE: [Ikvm-developers] Command line improvement for ikvmc

[Alan M. <Ala...@cr...>]

Hello,

Thanks for the suggestions.  I am attaching a new patch that incorporate
your suggestions for ikvmc/Compiler.cs.

The "^" was prepended to the regular expression so that you could just list
package names in the exclusion file and they would not be matched against
class names.  The "^" forces matches to occur at the start of a line.

On the other hand, not having the "^" allows for more powerful expression
matching and it is easy enough to add the symbol to the start of each line
in the exclusion file.  I have taken the symbol out of the attached patch.

I realize the short comings of the current debugging information but even
with just approximate line numbers, it makes it a lot easier to debug the
JITted assembly code.

Alan

-----
Alan Macek 
R&D - Crystal Decisions

-----Original Message-----
From: Jeroen Frijters [mailto:je...@su...] 
Sent: Wednesday, August 20, 2003 5:23 AM
To: Alan Macek; ikvm list
Subject: RE: [Ikvm-developers] Command line improvement for ikvmc


Hi Alan,

Thanks! It'll be a few days until I can make a new snapshot, as I'm still in
the middle of the netexp/Class.forName rewrite.

The patch looks good, but I do have a few small suggestions/questions:
- In ProcessExclusionFile you should use the using() construct, to make sure
the StreamReader is closed
- Why do you prepend a "^" to the regex?
- Calling JVM.PrepareForSaveDebugImage isn't needed
- I would catch the UnauthorizedAccessException in ProcessFile instead of in
Recurse
- Use Console.Error.WriteLine instead of Console.WriteLine for
errors/warnings

Also, be aware that while there is some support for writing debugging
symbols, this still has some major holes in it.

Regards,
Jeroen

> -----Original Message-----
> From: ikv...@li...
> [mailto:ikv...@li...] On
> Behalf Of Alan Macek
> Sent: Tuesday, August 19, 2003 23:35
> To: ikvm list
> Subject: [Ikvm-developers] Command line improvement for ikvmc
> 
> Hello,
> 
> I am attaching a patch for ikvmc\Compiler.cs and ik.vm.net\vm.cs to 
> allow for more command line arguments to ikvmc.  I look forward to 
> hearing comments or suggestions on these changes.
> 
> The two new command line arguments are:
> 1) '-debug' which turns on the production of debugging output.
> 
> 2) '-exclude:list.txt' which allows for the provision of an exclusion 
> list. Each line in the referenced text file contains a regular
> expression.  The
> compiler excludes any class matching one of the regular 
> expressions from the
> compilation.  I have been using this to eliminate classes 
> that refer to
> unsupported Java classes (such as Swing).  For instance, a 
> .jar file may
> contain many useful classes but one class may refer to a 
> non-existent class.
> To allow compilation of the remainder of the .jar, the one 
> class can be
> excluded.
> 
> These patches are against the latest snapshot.
> 
> Alan
> 
> -----
> Alan Macek
> R&D - Crystal Decisions
> 
>