RE: [Ikvm-developers] Command line improvement for ikvmc

[Jeroen F. <je...@su...>]

Hi Alan,

Thanks! It'll be a few days until I can make a new snapshot, as I'm
still in the middle of the netexp/Class.forName rewrite.

The patch looks good, but I do have a few small suggestions/questions:
- In ProcessExclusionFile you should use the using() construct, to make
sure the StreamReader is closed
- Why do you prepend a "^" to the regex?
- Calling JVM.PrepareForSaveDebugImage isn't needed
- I would catch the UnauthorizedAccessException in ProcessFile instead
of in Recurse
- Use Console.Error.WriteLine instead of Console.WriteLine for
errors/warnings

Also, be aware that while there is some support for writing debugging
symbols, this still has some major holes in it.

Regards,
Jeroen

> -----Original Message-----
> From: ikv...@li...=20
> [mailto:ikv...@li...] On=20
> Behalf Of Alan Macek
> Sent: Tuesday, August 19, 2003 23:35
> To: ikvm list
> Subject: [Ikvm-developers] Command line improvement for ikvmc
>=20
> Hello,
>=20
> I am attaching a patch for ikvmc\Compiler.cs and=20
> ik.vm.net\vm.cs to allow
> for more command line arguments to ikvmc.  I look forward to hearing
> comments or suggestions on these changes.
>=20
> The two new command line arguments are:
> 1) '-debug' which turns on the production of debugging output. =20
>=20
> 2) '-exclude:list.txt' which allows for the provision of an=20
> exclusion list.
> Each line in the referenced text file contains a regular=20
> expression.  The
> compiler excludes any class matching one of the regular=20
> expressions from the
> compilation.  I have been using this to eliminate classes=20
> that refer to
> unsupported Java classes (such as Swing).  For instance, a=20
> .jar file may
> contain many useful classes but one class may refer to a=20
> non-existent class.
> To allow compilation of the remainder of the .jar, the one=20
> class can be
> excluded.
>=20
> These patches are against the latest snapshot. =20
>=20
> Alan
>=20
> -----
> Alan Macek=20
> R&D - Crystal Decisions
>=20
>=20