Menu

#82 Latest changes to irc.py breaks with older python-irc package

v1.0 (example)
closed-fixed
nobody
None
5
2015-05-06
2015-04-30
No

Running with the latest changes results in the following error:

Traceback (most recent call last):
  File "/usr/lib/idjc/site-packages/idjc/irc.py", line 1209, in _on_row_inserted
    self.append(IRCConnection(model, path, self._stream_active))
  File "/usr/lib/idjc/site-packages/idjc/irc.py", line 1239, in __init__
    self.client = client.Reactor()
AttributeError: 'module' object has no attribute 'Reactor'

Apparently I have an older version of python-irc

brian@cyberman ~/Develop/idjc $ pip show irc
---
Name: irc
Version: 0.0.08.5.3
Location: /usr/lib/python2.7/dist-packages
Requires: six

I upgraded to the latest version of python-irc and that did fix the problem. But you may want to print a warning to upgrade python-irc, instead of allowing the Traceback.

Discussion

  • Stephen Fairchild

    Can you test the fix I just pushed?

     
  • Brian Millham

    Brian Millham - 2015-05-05

    I had to downgrade python-irc to the original version to test. Your fix works fine with my original python-irc. I then upgraded back to the latest version, and no problems with it either. Thanks for the fix!

     
  • Stephen Fairchild

    • status: open --> closed-fixed
     

Log in to post a comment.